mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jingyi Wang <quic_jingyw@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Rob Herring <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	"Richard Cochran" <richardcochran@gmail.com>,
	<quic_tengfan@quicinc.com>, <quic_tingweiz@quicinc.com>,
	<quic_aiquny@quicinc.com>, <linux-arm-msm@vger.kernel.org>,
	<linux-gpio@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] pinctrl: qcom: add the tlmm driver for QCS8300 platforms
Date: Fri, 11 Oct 2024 13:46:38 +0800	[thread overview]
Message-ID: <abc3516e-2c12-4612-9035-146b280b36df@quicinc.com> (raw)
In-Reply-To: <yh5qzohy42r226a4e7yupimfdl6xccpntuffot7dnhrftagtae@4ruw5vmcknfq>



On 10/10/2024 8:56 PM, Dmitry Baryshkov wrote:
> On Wed, Oct 09, 2024 at 03:13:34PM GMT, Jingyi Wang wrote:
>> Add support for QCS8300 TLMM configuration and control via the
>> pinctrl framework.
>>
>> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com>
>> ---
>>  drivers/pinctrl/qcom/Kconfig.msm       |    7 +
>>  drivers/pinctrl/qcom/Makefile          |    1 +
>>  drivers/pinctrl/qcom/pinctrl-qcs8300.c | 1246 ++++++++++++++++++++++++++++++++
>>  3 files changed, 1254 insertions(+)
>>
> 
> [...]
> 
>> +	[125] = PINGROUP(125, phase_flag, _, _, _, _, _, _, _, _, _, egpio),
>> +	[126] = PINGROUP(126, _, _, _, _, _, _, _, _, _, _, egpio),
>> +	[127] = PINGROUP(127, _, _, _, _, _, _, _, _, _, _, egpio),
>> +	[128] = PINGROUP(128, _, _, _, _, _, _, _, _, _, _, egpio),
>> +	[129] = PINGROUP(129, _, _, _, _, _, _, _, _, _, _, egpio),
>> +	[130] = PINGROUP(130, _, _, _, _, _, _, _, _, _, _, egpio),
>> +	[131] = PINGROUP(131, _, _, _, _, _, _, _, _, _, _, egpio),
>> +	[132] = PINGROUP(132, _, _, _, _, _, _, _, _, _, _, egpio),
>> +	[133] = UFS_RESET(ufs_reset, 0x92000),
>> +	[134] = SDC_QDSD_PINGROUP(sdc1_rclk, 0x89000, 15, 0),
>> +	[135] = SDC_QDSD_PINGROUP(sdc1_clk, 0x89000, 13, 6),
>> +	[136] = SDC_QDSD_PINGROUP(sdc1_cmd, 0x89000, 11, 3),
>> +	[137] = SDC_QDSD_PINGROUP(sdc1_data, 0x89000, 9, 0),
>> +};
>> +
> 
> [...]
> 
>> +
>> +static const struct msm_pinctrl_soc_data qcs8300_pinctrl = {
>> +	.pins = qcs8300_pins,
>> +	.npins = ARRAY_SIZE(qcs8300_pins),
>> +	.functions = qcs8300_functions,
>> +	.nfunctions = ARRAY_SIZE(qcs8300_functions),
>> +	.groups = qcs8300_groups,
>> +	.ngroups = ARRAY_SIZE(qcs8300_groups),
>> +	.ngpios = 134,
> 
> I believe this should be 133.
> 
133 should be right, thanks for review, will fix that.
>> +	.wakeirq_map = qcs8300_pdc_map,
>> +	.nwakeirq_map = ARRAY_SIZE(qcs8300_pdc_map),
>> +	.egpio_func = 11,
>> +};
>> +
> 
Thanks,
Jingyi


  reply	other threads:[~2024-10-11  5:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-09  7:13 [PATCH v2 0/2] pinctrl: qcom: Introduce Pinctrl for QCS8300 Jingyi Wang
2024-10-09  7:13 ` [PATCH v2 1/2] dt-bindings: pinctrl: describe qcs8300-tlmm Jingyi Wang
2024-10-09  7:13 ` [PATCH v2 2/2] pinctrl: qcom: add the tlmm driver for QCS8300 platforms Jingyi Wang
2024-10-10 12:56   ` Dmitry Baryshkov
2024-10-11  5:46     ` Jingyi Wang [this message]
2024-10-16  9:25   ` Uwe Kleine-König
2024-10-17  2:24     ` Jingyi Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abc3516e-2c12-4612-9035-146b280b36df@quicinc.com \
    --to=quic_jingyw@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=krzk+dt@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=quic_aiquny@quicinc.com \
    --cc=quic_tengfan@quicinc.com \
    --cc=quic_tingweiz@quicinc.com \
    --cc=richardcochran@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®