From: Vignesh Raghavendra <vigneshr@ti.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>,
Nishanth Menon <nm@ti.com>, Lokesh Vutla <lokeshvutla@ti.com>,
Tero Kristo <kristo@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: ti: k3-am642-main: fix ports mac properties
Date: Wed, 9 Jun 2021 10:42:44 +0530 [thread overview]
Message-ID: <abe15d92-83a7-d60f-c4b4-81e8b9ac415a@ti.com> (raw)
In-Reply-To: <20210608184940.25934-1-grygorii.strashko@ti.com>
On 6/9/21 12:19 AM, Grygorii Strashko wrote:
> The current device tree CPSW3g node adds non-zero "mac-address" property to
> the ports, which prevents random MAC address assignment to network devices
> if bootloader failed to update DT. This may cause more then one host to
> have the same MAC in the network.
>
> mac-address = [00 00 de ad be ef];
> mac-address = [00 01 de ad be ef];
>
> In addition, there is one MAC address available in eFuse registers which
> can be used for default port 1.
>
> Hence, fix ports MAC properties by:
> - resetting "mac-address" property to 0
> - adding ti,syscon-efuse = <&main_conf 0x200> to Port 1
>
> Fixes: 3753b12877b6 ("arm64: dts: ti: k3-am64-main: Add CPSW DT node")
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com>
> arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> index effb9d2e3c25..7f7178a7a055 100644
> --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> @@ -514,7 +514,8 @@
> ti,mac-only;
> label = "port1";
> phys = <&phy_gmii_sel 1>;
> - mac-address = [00 00 de ad be ef];
> + mac-address = [00 00 00 00 00 00];
> + ti,syscon-efuse = <&main_conf 0x200>;
> };
>
> cpsw_port2: port@2 {
> @@ -522,7 +523,7 @@
> ti,mac-only;
> label = "port2";
> phys = <&phy_gmii_sel 2>;
> - mac-address = [00 01 de ad be ef];
> + mac-address = [00 00 00 00 00 00];
> };
> };
>
>
next prev parent reply other threads:[~2021-06-09 5:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 18:49 Grygorii Strashko
2021-06-09 5:12 ` Vignesh Raghavendra [this message]
2021-06-11 19:01 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abe15d92-83a7-d60f-c4b4-81e8b9ac415a@ti.com \
--to=vigneshr@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®