* [PATCH] ubifs/lpt_commit: remove return at end of void function
@ 2024-12-06 13:05 Pintu Kumar
2024-12-07 2:54 ` Zhihao Cheng
0 siblings, 1 reply; 2+ messages in thread
From: Pintu Kumar @ 2024-12-06 13:05 UTC (permalink / raw)
To: richard, chengzhihao1, linux-mtd, linux-kernel
Cc: skhan, pintu.ping, Pintu Kumar
Noticed that there is a useless return statement at the end of void
function dump_lpt_leb().
Just removing it.
Signed-off-by: Pintu Kumar <quic_pintu@quicinc.com>
---
fs/ubifs/lpt_commit.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ubifs/lpt_commit.c b/fs/ubifs/lpt_commit.c
index aa8837e6247c..f2cb214581fd 100644
--- a/fs/ubifs/lpt_commit.c
+++ b/fs/ubifs/lpt_commit.c
@@ -1932,7 +1932,6 @@ static void dump_lpt_leb(const struct ubifs_info *c, int lnum)
pr_err("(pid %d) finish dumping LEB %d\n", current->pid, lnum);
out:
vfree(buf);
- return;
}
/**
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ubifs/lpt_commit: remove return at end of void function
2024-12-06 13:05 [PATCH] ubifs/lpt_commit: remove return at end of void function Pintu Kumar
@ 2024-12-07 2:54 ` Zhihao Cheng
0 siblings, 0 replies; 2+ messages in thread
From: Zhihao Cheng @ 2024-12-07 2:54 UTC (permalink / raw)
To: Pintu Kumar, richard, linux-mtd, linux-kernel; +Cc: skhan, pintu.ping
在 2024/12/6 21:05, Pintu Kumar 写道:
> Noticed that there is a useless return statement at the end of void
> function dump_lpt_leb().
> Just removing it.
>
> Signed-off-by: Pintu Kumar <quic_pintu@quicinc.com>
> ---
> fs/ubifs/lpt_commit.c | 1 -
> 1 file changed, 1 deletion(-)
Hi, Pintu. The title of the patch should be something like "ubifs:
dump_lpt_leb: remove return at end of void function". See
Documentation/process/submitting-patches.rst. Otherwise,
Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
>
> diff --git a/fs/ubifs/lpt_commit.c b/fs/ubifs/lpt_commit.c
> index aa8837e6247c..f2cb214581fd 100644
> --- a/fs/ubifs/lpt_commit.c
> +++ b/fs/ubifs/lpt_commit.c
> @@ -1932,7 +1932,6 @@ static void dump_lpt_leb(const struct ubifs_info *c, int lnum)
> pr_err("(pid %d) finish dumping LEB %d\n", current->pid, lnum);
> out:
> vfree(buf);
> - return;
> }
>
> /**
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-12-07 2:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-06 13:05 [PATCH] ubifs/lpt_commit: remove return at end of void function Pintu Kumar
2024-12-07 2:54 ` Zhihao Cheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®