From: Alexandre Torgue <alexandre.torgue@st.com>
To: Rob Herring <robh@kernel.org>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
Russell King <linux@armlinux.org.uk>,
Olof Johansson <olof@lixom.net>,
Patrice Chotard <patrice.chotard@st.com>, <lee.jones@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/8] Documentation: dt: Add new compatible to STM32 pinctrl driver bindings
Date: Wed, 1 Feb 2017 16:58:23 +0100 [thread overview]
Message-ID: <abee01c1-da4f-97b4-258a-3ab937f620eb@st.com> (raw)
In-Reply-To: <20170201150609.cbhwon76m6igmhyh@rob-hp-laptop>
On 02/01/2017 04:06 PM, Rob Herring wrote:
> On Fri, Jan 27, 2017 at 05:15:19PM +0100, Alexandre TORGUE wrote:
>> Add new compatible for stm32f469 MCU.
>>
>> Signed-off-by: Alexandre TORGUE <alexandre.torgue@st.com>
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
>> index 25d9809..4f0487d 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
>> +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
>> @@ -9,7 +9,8 @@ Pin controller node:
>> Required properies:
>> - compatible: value should be one of the following:
>> (a) "st,stm32f429-pinctrl"
>> - (b) "st,stm32f746-pinctrl"
>> + (b) "st,stm32f469-pinctrl"
>> + (c) "st,stm32f746-pinctrl"
>
> Drop the a,b,c. Otherwise, you'll be changing a bunch of lines every
> time.
I completely agree.
Linus, Do i need to send a v2 for this patch ?
>
> With that,
>
> Acked-by: Rob Herring <robh@kernel.org>
>
>
>> - #address-cells: The value of this property must be 1
>> - #size-cells : The value of this property must be 1
>> - ranges : defines mapping between pin controller node (parent) to
>> --
>> 1.9.1
>>
next prev parent reply other threads:[~2017-02-01 15:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 16:15 [PATCH 0/8] Add STM32F469 pinctrl and fix issues in STM32 pinctrl Alexandre TORGUE
2017-01-27 16:15 ` [PATCH 1/8] pinctrl: stm32: fix bad location of gpiochip_lock_as_irq Alexandre TORGUE
2017-01-30 15:15 ` Linus Walleij
2017-01-27 16:15 ` [PATCH 2/8] pinctrl: stm32: use gpio-ranges to declare bank range Alexandre TORGUE
2017-01-30 15:19 ` Linus Walleij
2017-01-30 16:29 ` Alexandre Torgue
2017-02-01 15:01 ` Linus Walleij
2017-03-27 10:23 ` Alexandre Torgue
2017-01-27 16:15 ` [PATCH 3/8] Documentation: dt: Add bindings for STM32 pinctrl Alexandre TORGUE
2017-02-01 15:04 ` Rob Herring
2017-02-06 8:45 ` Linus Walleij
2017-01-27 16:15 ` [PATCH 4/8] includes: dt-bindings: Rename STM32F429 pinctrl DT bindings Alexandre TORGUE
2017-01-27 16:15 ` [PATCH 5/8] pinctrl: stm32: Add STM32F469 MCU support Alexandre TORGUE
2017-01-27 16:15 ` [PATCH 6/8] Documentation: dt: Add new compatible to STM32 pinctrl driver bindings Alexandre TORGUE
2017-02-01 15:06 ` Rob Herring
2017-02-01 15:58 ` Alexandre Torgue [this message]
2017-02-06 8:46 ` Linus Walleij
2017-02-06 11:21 ` Alexandre Torgue
2017-01-27 16:15 ` [PATCH 7/8] ARM: Kconfig: Introduce MACH_STM32F469 flag Alexandre TORGUE
2017-01-27 16:15 ` [PATCH 8/8] ARM: dts: stm32: create dedicated files for pinctrl definitions Alexandre TORGUE
2017-01-30 14:55 ` [PATCH 0/8] Add STM32F469 pinctrl and fix issues in STM32 pinctrl Alexandre Torgue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abee01c1-da4f-97b4-258a-3ab937f620eb@st.com \
--to=alexandre.torgue@st.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=olof@lixom.net \
--cc=patrice.chotard@st.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®