From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Cc: Lee Jones <lee@kernel.org>, Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2 2/3] gpio: timberdale: use device properties
Date: Mon, 16 Mar 2026 17:09:25 +0200 [thread overview]
Message-ID: <abgdJa8ETXH8qGpO@ashevche-desk.local> (raw)
In-Reply-To: <20260316-gpio-timberdale-swnode-v2-2-ea0078066871@oss.qualcomm.com>
On Mon, Mar 16, 2026 at 10:30:49AM +0100, Bartosz Golaszewski wrote:
> The top-level MFD driver now passes the device properties to the GPIO
> cell via the software node. Use generic device property accessors and
> stop using platform data. We can ignore the "ngpios" property here now
> as it will be retrieved internally by GPIO core.
...
> int irq = platform_get_irq(pdev, 0);
> gc->to_irq = (irq >= 0 && tgpio->irq_base > 0) ? timbgpio_to_irq : NULL;
> if (irq < 0 || tgpio->irq_base <= 0)
> return 0;
I believe we also want to have a fix of the above (it will print a message when
it's fine to continue and checks for irq > 0 twice).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-16 15:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 9:30 [PATCH v2 0/3] gpio: timberdale: remove platform data header Bartosz Golaszewski
2026-03-16 9:30 ` [PATCH v2 1/3] mfd: timberdale: set up a software node for the GPIO cell Bartosz Golaszewski
2026-03-26 10:52 ` Lee Jones
2026-03-26 13:41 ` Bartosz Golaszewski
2026-03-16 9:30 ` [PATCH v2 2/3] gpio: timberdale: use device properties Bartosz Golaszewski
2026-03-16 15:09 ` Andy Shevchenko [this message]
2026-03-16 9:30 ` [PATCH v2 3/3] gpio: timberdale: remove platform data header Bartosz Golaszewski
2026-03-16 15:10 ` [PATCH v2 0/3] " Andy Shevchenko
2026-03-19 13:39 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abgdJa8ETXH8qGpO@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=lee@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®