From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/vsprintf: Validate sleepable context during restrictred pointer formatting
Date: Tue, 17 Mar 2026 16:07:56 +0200 [thread overview]
Message-ID: <ablgPLnpaprd6OoO@ashevche-desk.local> (raw)
In-Reply-To: <20260317-restricted-pointers-final-v1-1-b4dca0ed6483@linutronix.de>
On Tue, Mar 17, 2026 at 12:41:23PM +0100, Thomas Weißschuh wrote:
> Depending on the system configuration, the restricted pointer formatting
> might call into the security subsystem which might sleep.
> As %pK is intended to be only used from read handlers of virtual files,
> which always run in task context, this should never happen in practice.
> However, developers have used %pK before from atomic context without
> realizing this restriction. While all existing user of %pK through
> printk() have been removed, new ones might be reintroduced accidentally
> in the future.
>
> Add a might_sleep(), so that misuse of %pK from atomic context is
> detected right away.
...
> + /* Only usable from task context, The call to has_capability_noaudit() might sleep. */
> + might_sleep();
Yeah, but for kptr_restrict != 1 it's not true. Perhaps might_sleep_if() ?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-17 14:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 11:41 Thomas Weißschuh
2026-03-17 14:07 ` Andy Shevchenko [this message]
2026-03-17 14:26 ` Thomas Weißschuh
2026-03-17 17:24 ` Steven Rostedt
2026-03-18 8:48 ` Thomas Weißschuh
2026-03-18 11:01 ` Petr Mladek
2026-03-18 11:03 ` Petr Mladek
2026-03-18 13:59 ` Sebastian Andrzej Siewior
2026-03-18 14:45 ` Thomas Weißschuh
2026-03-18 14:57 ` Sebastian Andrzej Siewior
2026-03-18 15:10 ` Thomas Weißschuh
2026-03-19 8:17 ` Sebastian Andrzej Siewior
2026-03-20 1:53 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ablgPLnpaprd6OoO@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=thomas.weissschuh@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome