From: Jiangfeng Xiao <xiaojiangfeng@huawei.com>
To: David Miller <davem@davemloft.net>
Cc: <yisen.zhuang@huawei.com>, <salil.mehta@huawei.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<leeyou.li@huawei.com>, <zhanghan23@huawei.com>,
<nixiaoming@huawei.com>, <zhangqiang.cn@hisilicon.com>,
<dingjingcheng@hisilicon.com>
Subject: Re: [PATCH] net: hisilicon: Fix ping latency when deal with high throughput
Date: Mon, 28 Oct 2019 09:27:12 +0800 [thread overview]
Message-ID: <ac37d6f4-1cde-5d00-095c-43362cb4a097@huawei.com> (raw)
In-Reply-To: <20191026.112235.711416398803098524.davem@davemloft.net>
On 2019/10/27 2:22, David Miller wrote:
> From: Jiangfeng Xiao <xiaojiangfeng@huawei.com>
> Date: Sat, 26 Oct 2019 16:49:39 +0800
>
>> diff --git a/drivers/net/ethernet/hisilicon/hip04_eth.c b/drivers/net/ethernet/hisilicon/hip04_eth.c
>> index ad6d912..78f338a 100644
>> --- a/drivers/net/ethernet/hisilicon/hip04_eth.c
>> +++ b/drivers/net/ethernet/hisilicon/hip04_eth.c
>> @@ -575,7 +575,7 @@ static int hip04_rx_poll(struct napi_struct *napi, int budget)
>> struct hip04_priv *priv = container_of(napi, struct hip04_priv, napi);
>> struct net_device *ndev = priv->ndev;
>> struct net_device_stats *stats = &ndev->stats;
>> - unsigned int cnt = hip04_recv_cnt(priv);
>> + static unsigned int cnt_remaining;
>
> There is no way a piece of software state should be system wide, this is
> a per device instance value.
>
> .
>
Thank you for your guidance, I will fix it in v2.
prev parent reply other threads:[~2019-10-28 1:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-26 8:49 Jiangfeng Xiao
2019-10-26 15:44 ` Joe Perches
2019-10-28 1:24 ` Jiangfeng Xiao
2019-10-26 18:22 ` David Miller
2019-10-28 1:27 ` Jiangfeng Xiao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac37d6f4-1cde-5d00-095c-43362cb4a097@huawei.com \
--to=xiaojiangfeng@huawei.com \
--cc=davem@davemloft.net \
--cc=dingjingcheng@hisilicon.com \
--cc=leeyou.li@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nixiaoming@huawei.com \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
--cc=zhanghan23@huawei.com \
--cc=zhangqiang.cn@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®