From: Joe Perches <joe@perches.com>
To: Jiangfeng Xiao <xiaojiangfeng@huawei.com>,
davem@davemloft.net, yisen.zhuang@huawei.com,
salil.mehta@huawei.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
leeyou.li@huawei.com, zhanghan23@huawei.com,
nixiaoming@huawei.com, zhangqiang.cn@hisilicon.com,
dingjingcheng@hisilicon.com
Subject: Re: [PATCH] net: hisilicon: Fix ping latency when deal with high throughput
Date: Sat, 26 Oct 2019 08:44:47 -0700 [thread overview]
Message-ID: <cfde329c7ee3c9bb5610bd9b040f95214cc4d9e8.camel@perches.com> (raw)
In-Reply-To: <1572079779-76449-1-git-send-email-xiaojiangfeng@huawei.com>
On Sat, 2019-10-26 at 16:49 +0800, Jiangfeng Xiao wrote:
> This is due to error in over budget processing.
> When dealing with high throughput, the used buffers
> that exceeds the budget is not cleaned up. In addition,
> it takes a lot of cycles to clean up the used buffer,
> and then the buffer where the valid data is located can take effect.
[]
> diff --git a/drivers/net/ethernet/hisilicon/hip04_eth.c b/drivers/net/ethernet/hisilicon/hip04_eth.c
[]
> @@ -575,7 +575,7 @@ static int hip04_rx_poll(struct napi_struct *napi, int budget)
> struct hip04_priv *priv = container_of(napi, struct hip04_priv, napi);
> struct net_device *ndev = priv->ndev;
> struct net_device_stats *stats = &ndev->stats;
> - unsigned int cnt = hip04_recv_cnt(priv);
> + static unsigned int cnt_remaining;
static doesn't seem a great idea here as it's for just a single
driver instance. Maybe make this part of struct hip04_priv?
next prev parent reply other threads:[~2019-10-26 15:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-26 8:49 Jiangfeng Xiao
2019-10-26 15:44 ` Joe Perches [this message]
2019-10-28 1:24 ` Jiangfeng Xiao
2019-10-26 18:22 ` David Miller
2019-10-28 1:27 ` Jiangfeng Xiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfde329c7ee3c9bb5610bd9b040f95214cc4d9e8.camel@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=dingjingcheng@hisilicon.com \
--cc=leeyou.li@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nixiaoming@huawei.com \
--cc=salil.mehta@huawei.com \
--cc=xiaojiangfeng@huawei.com \
--cc=yisen.zhuang@huawei.com \
--cc=zhanghan23@huawei.com \
--cc=zhangqiang.cn@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®