mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zenghui Yu <yuzenghui@huawei.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<cohuck@redhat.com>, <wanghaibin.wang@huawei.com>
Subject: Re: [PATCH 1/2] vfio/pci: Remove redundant declaration of vfio_pci_driver
Date: Sat, 19 Sep 2020 09:56:43 +0800	[thread overview]
Message-ID: <ac4c01e5-df0e-1a18-6a1e-d50f37ddafb7@huawei.com> (raw)
In-Reply-To: <20200917162240.037a1913@x1.home>

On 2020/9/18 6:22, Alex Williamson wrote:
> On Thu, 17 Sep 2020 11:31:27 +0800
> Zenghui Yu <yuzenghui@huawei.com> wrote:
> 
>> It was added by commit 137e5531351d ("vfio/pci: Add sriov_configure
>> support") and actually unnecessary. Remove it.
> 
> Looks correct, but I might clarify as:
> 
> s/unnecessary/duplicates a forward declaration earlier in the file/
> 
> I can change on commit if you approve.  Thanks,

Indeed. Please help to change it.


Thanks,
Zenghui

      reply	other threads:[~2020-09-19  1:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-17  3:31 Zenghui Yu
2020-09-17  3:31 ` [PATCH 2/2] vfio/pci: Remove bardirty from vfio_pci_device Zenghui Yu
2020-09-17 11:35   ` Cornelia Huck
2020-09-17 22:07     ` Alex Williamson
2020-09-19  1:54       ` Zenghui Yu
2020-09-19  2:11         ` Alex Williamson
2020-09-19  2:39           ` Zenghui Yu
2020-09-17 11:26 ` [PATCH 1/2] vfio/pci: Remove redundant declaration of vfio_pci_driver Cornelia Huck
2020-09-17 22:22 ` Alex Williamson
2020-09-19  1:56   ` Zenghui Yu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac4c01e5-df0e-1a18-6a1e-d50f37ddafb7@huawei.com \
    --to=yuzenghui@huawei.com \
    --cc=alex.williamson@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wanghaibin.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®