From: Zenghui Yu <yuzenghui@huawei.com>
To: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <alex.williamson@redhat.com>, <cohuck@redhat.com>,
<wanghaibin.wang@huawei.com>, Zenghui Yu <yuzenghui@huawei.com>
Subject: [PATCH 2/2] vfio/pci: Remove bardirty from vfio_pci_device
Date: Thu, 17 Sep 2020 11:31:28 +0800 [thread overview]
Message-ID: <20200917033128.872-2-yuzenghui@huawei.com> (raw)
In-Reply-To: <20200917033128.872-1-yuzenghui@huawei.com>
It isn't clear what purpose the @bardirty serves. It might be used to avoid
the unnecessary vfio_bar_fixup() invoking on a user-space BAR read, which
is not required when bardirty is unset.
The variable was introduced in commit 89e1f7d4c66d ("vfio: Add PCI device
driver") but never actually used, so it shouldn't be that important. Remove
it.
Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
---
drivers/vfio/pci/vfio_pci_config.c | 7 -------
drivers/vfio/pci/vfio_pci_private.h | 1 -
2 files changed, 8 deletions(-)
diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c
index d98843feddce..e93b287fea02 100644
--- a/drivers/vfio/pci/vfio_pci_config.c
+++ b/drivers/vfio/pci/vfio_pci_config.c
@@ -507,8 +507,6 @@ static void vfio_bar_fixup(struct vfio_pci_device *vdev)
*vbar &= cpu_to_le32((u32)mask);
} else
*vbar = 0;
-
- vdev->bardirty = false;
}
static int vfio_basic_config_read(struct vfio_pci_device *vdev, int pos,
@@ -633,9 +631,6 @@ static int vfio_basic_config_write(struct vfio_pci_device *vdev, int pos,
}
}
- if (is_bar(offset))
- vdev->bardirty = true;
-
return count;
}
@@ -1697,8 +1692,6 @@ int vfio_config_init(struct vfio_pci_device *vdev)
if (ret)
goto out;
- vdev->bardirty = true;
-
/*
* XXX can we just pci_load_saved_state/pci_restore_state?
* may need to rebuild vconfig after that
diff --git a/drivers/vfio/pci/vfio_pci_private.h b/drivers/vfio/pci/vfio_pci_private.h
index 61ca8ab165dc..dc96a0fda548 100644
--- a/drivers/vfio/pci/vfio_pci_private.h
+++ b/drivers/vfio/pci/vfio_pci_private.h
@@ -122,7 +122,6 @@ struct vfio_pci_device {
bool virq_disabled;
bool reset_works;
bool extended_caps;
- bool bardirty;
bool has_vga;
bool needs_reset;
bool nointx;
--
2.19.1
next prev parent reply other threads:[~2020-09-17 3:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 3:31 [PATCH 1/2] vfio/pci: Remove redundant declaration of vfio_pci_driver Zenghui Yu
2020-09-17 3:31 ` Zenghui Yu [this message]
2020-09-17 11:35 ` [PATCH 2/2] vfio/pci: Remove bardirty from vfio_pci_device Cornelia Huck
2020-09-17 22:07 ` Alex Williamson
2020-09-19 1:54 ` Zenghui Yu
2020-09-19 2:11 ` Alex Williamson
2020-09-19 2:39 ` Zenghui Yu
2020-09-17 11:26 ` [PATCH 1/2] vfio/pci: Remove redundant declaration of vfio_pci_driver Cornelia Huck
2020-09-17 22:22 ` Alex Williamson
2020-09-19 1:56 ` Zenghui Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917033128.872-2-yuzenghui@huawei.com \
--to=yuzenghui@huawei.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wanghaibin.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®