From: Werner Sembach <wse@tuxedocomputers.com>
To: "Uwe Kleine-König" <ukleinek@kernel.org>,
"Luis Chamberlain" <mcgrof@kernel.org>
Cc: tux@tuxedocomputers.com, Petr Pavlu <petr.pavlu@suse.com>,
Sami Tolvanen <samitolvanen@google.com>,
Daniel Gomez <da.gomez@samsung.com>,
linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
Thorsten Leemhuis <linux@leemhuis.info>
Subject: Re: [PATCH 2/2] module: Block modules by Tuxedo from accessing GPL symbols
Date: Mon, 18 Nov 2024 11:11:53 +0100 [thread overview]
Message-ID: <ac82a35e-4fe0-4f22-a371-59a546fdab18@tuxedocomputers.com> (raw)
In-Reply-To: <20241114103133.547032-6-ukleinek@kernel.org>
Hi,
Am 14.11.24 um 11:31 schrieb Uwe Kleine-König:
> Tuxedo licenses the modules used on their hardware under GPLv3+, to
> "keep control of the upstream pacing" – and want to re-license the code
> while upstreaming.
>
> They were asked to then at least not use MODULE_LICENSE("GPL") which
> declares compatibility to the kernel's GPLv2. They accepted the pull
> request and shortly after reverted the change and so continue to lie
> about the license.
>
> So teach the module loader that these modules are proprietary despite
> their declaration to be GPLv2 compatible "until the legal stuff is
> sorted out".
The relicensing is complete so this patch can be dropped entirely (everything is
now GPLv2+)
Regards,
Werner Sembach
>
> Link: https://gitlab.com/tuxedocomputers/development/packages/tuxedo-drivers/-/commit/a8c09b6c2ce6393fe39d8652d133af9f06cfb427
> Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org>
> ---
> kernel/module/main.c | 33 +++++++++++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/kernel/module/main.c b/kernel/module/main.c
> index 878191c65efc..46badbb09d5e 100644
> --- a/kernel/module/main.c
> +++ b/kernel/module/main.c
> @@ -2338,6 +2338,39 @@ static const char *module_license_offenders[] = {
>
> /* lve claims to be GPL but upstream won't provide source */
> "lve",
> +
> + /*
> + * Tuxedo distributes their kernel modules under GPLv3, but intentially
> + * lies in their MODULE_LICENSE() calls.
> + * See https://gitlab.com/tuxedocomputers/development/packages/tuxedo-drivers/-/commit/a8c09b6c2ce6393fe39d8652d133af9f06cfb427
> + */
> + "gxtp7380",
> + "ite_8291",
> + "ite_8291_lb",
> + "ite_8297",
> + "ite_829x",
> + "stk8321",
> + "tuxedo_compatibility_check",
> + "tuxedo_io",
> + "tuxedo_nb02_nvidia_power_ctrl",
> + "tuxedo_nb04_keyboard",
> + "tuxedo_nb04_wmi_ab",
> + "tuxedo_nb04_wmi_bs",
> + "tuxedo_nb04_sensors",
> + "tuxedo_nb04_power_profiles",
> + "tuxedo_nb04_kbd_backlight",
> + "tuxedo_nb05_keyboard",
> + "tuxedo_nb05_kbd_backlight",
> + "tuxedo_nb05_power_profiles",
> + "tuxedo_nb05_ec",
> + "tuxedo_nb05_sensors",
> + "tuxedo_nb05_fan_control",
> + "tuxi_acpi",
> + "tuxedo_tuxi_fan_control",
> + "clevo_wmi",
> + "tuxedo_keyboard",
> + "clevo_acpi",
> + "uniwill_wmi",
> };
>
> /*
next prev parent reply other threads:[~2024-11-18 10:11 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20241114103151eucas1p133de0b231bf06bf8cd42621347a0ed17@eucas1p1.samsung.com>
2024-11-14 10:31 ` [PATCH 0/2] " Uwe Kleine-König
2024-11-14 10:31 ` [PATCH 1/2] module: Put known GPL offenders in an array Uwe Kleine-König
2024-11-14 16:08 ` Christoph Hellwig
2024-11-15 4:40 ` Greg KH
2024-11-14 10:31 ` [PATCH 2/2] module: Block modules by Tuxedo from accessing GPL symbols Uwe Kleine-König
2024-11-14 11:56 ` Daniel Gomez
2024-11-15 4:40 ` Greg KH
2024-11-14 16:09 ` Christoph Hellwig
2024-11-14 19:21 ` Aaron Rainbolt
2024-11-14 23:06 ` Al Viro
2024-11-15 4:40 ` Greg KH
2024-11-18 10:11 ` Werner Sembach [this message]
2024-11-14 10:49 ` [PATCH 0/2] " Werner Sembach
2024-11-14 11:14 ` Uwe Kleine-König
2024-11-14 11:44 ` Werner Sembach
2024-11-16 17:49 ` Uwe Kleine-König
2024-11-16 18:41 ` Werner Sembach
2024-11-15 4:43 ` Greg KH
2024-11-15 6:09 ` Werner Sembach
2024-11-15 6:30 ` Greg KH
2024-11-15 7:29 ` Uwe Kleine-König
2024-11-15 9:00 ` Werner Sembach
2024-11-15 9:18 ` Greg KH
2024-11-15 9:40 ` Werner Sembach
2024-11-15 10:22 ` Greg KH
2024-11-15 10:59 ` Werner Sembach
2024-11-15 12:01 ` Greg KH
2024-11-15 10:51 ` Uwe Kleine-König
2024-11-15 11:01 ` Werner Sembach
2024-11-14 11:50 ` Daniel Gomez
2024-11-20 14:11 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac82a35e-4fe0-4f22-a371-59a546fdab18@tuxedocomputers.com \
--to=wse@tuxedocomputers.com \
--cc=da.gomez@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux@leemhuis.info \
--cc=mcgrof@kernel.org \
--cc=petr.pavlu@suse.com \
--cc=samitolvanen@google.com \
--cc=tux@tuxedocomputers.com \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®