From: "Uwe Kleine-König" <ukleinek@kernel.org>
To: Werner Sembach <wse@tuxedocomputers.com>,
Luis Chamberlain <mcgrof@kernel.org>
Cc: tux@tuxedocomputers.com, Petr Pavlu <petr.pavlu@suse.com>,
Sami Tolvanen <samitolvanen@google.com>,
Daniel Gomez <da.gomez@samsung.com>,
linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
Thorsten Leemhuis <linux@leemhuis.info>
Subject: Re: [PATCH 0/2] module: Block modules by Tuxedo from accessing GPL symbols
Date: Thu, 14 Nov 2024 12:14:16 +0100 [thread overview]
Message-ID: <e7d97b3d-1880-4c89-bbf2-a742d6ac9e6b@kernel.org> (raw)
In-Reply-To: <e32e9f5c-3841-41f7-9728-f998f123cc8a@tuxedocomputers.com>
Hello,
On 11/14/24 11:49, Werner Sembach wrote:
> Am 14.11.24 um 11:31 schrieb Uwe Kleine-König:
>> the kernel modules provided by Tuxedo on
>> https://gitlab.com/tuxedocomputers/development/packages/tuxedo-drivers
>> are licensed under GPLv3 or later. This is incompatible with the
>> kernel's license and so makes it impossible for distributions and other
>> third parties to support these at least in pre-compiled form and so
>> limits user experience and the possibilities to work on mainlining these
>> drivers.
>>
>> This incompatibility is created on purpose to control the upstream
>> process. See https://fosstodon.org/@kernellogger/113423314337991594 for
>> a nice summary of the situation and some further links about the issue.
>>
>> Note that the pull request that fixed the MODULE_LICENSE invocations to
>> stop claiming GPL(v2) compatibility was accepted and then immediately
>> reverted "for the time being until the legal stuff is sorted out"
>> (https://gitlab.com/tuxedocomputers/development/packages/tuxedo-
>> drivers/-/commit/a8c09b6c2ce6393fe39d8652d133af9f06cfb427).
>
> As already being implied by that commit message, this is sadly not an
> issue that can be sorted out over night.
>
> We ended up in this situation as MODULE_LICENSE("GPL") on its own does
> not hint at GPL v2, if one is not aware of the license definition table
> in the documentation.
That statement isn't consistent with you saying to pick GPLv3 as an
explicitly incompatible license to control the mainlining process. So
you knew that it's legally at least questionable to combine these licenses.
The only thing I could accept here is that you were surprised that the
incompatibility has some technical enforcement resulting in your modules
to become nonfunctional. But that's like a thieve in a supermarket who
asks for forgiveness because while he was aware that steeling is not
allowed, wasn't aware there is video surveillance that might actually
catch him.
So I'd claim MODULE_LICENSE("GPL") not being explicit to not apply for
GPLv3 code is not a valid excuse. (Which doesn't mean the kernel
couldn't improve here.)
Best regards
Uwe
next prev parent reply other threads:[~2024-11-14 11:14 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20241114103151eucas1p133de0b231bf06bf8cd42621347a0ed17@eucas1p1.samsung.com>
2024-11-14 10:31 ` Uwe Kleine-König
2024-11-14 10:31 ` [PATCH 1/2] module: Put known GPL offenders in an array Uwe Kleine-König
2024-11-14 16:08 ` Christoph Hellwig
2024-11-15 4:40 ` Greg KH
2024-11-14 10:31 ` [PATCH 2/2] module: Block modules by Tuxedo from accessing GPL symbols Uwe Kleine-König
2024-11-14 11:56 ` Daniel Gomez
2024-11-15 4:40 ` Greg KH
2024-11-14 16:09 ` Christoph Hellwig
2024-11-14 19:21 ` Aaron Rainbolt
2024-11-14 23:06 ` Al Viro
2024-11-15 4:40 ` Greg KH
2024-11-18 10:11 ` Werner Sembach
2024-11-14 10:49 ` [PATCH 0/2] " Werner Sembach
2024-11-14 11:14 ` Uwe Kleine-König [this message]
2024-11-14 11:44 ` Werner Sembach
2024-11-16 17:49 ` Uwe Kleine-König
2024-11-16 18:41 ` Werner Sembach
2024-11-15 4:43 ` Greg KH
2024-11-15 6:09 ` Werner Sembach
2024-11-15 6:30 ` Greg KH
2024-11-15 7:29 ` Uwe Kleine-König
2024-11-15 9:00 ` Werner Sembach
2024-11-15 9:18 ` Greg KH
2024-11-15 9:40 ` Werner Sembach
2024-11-15 10:22 ` Greg KH
2024-11-15 10:59 ` Werner Sembach
2024-11-15 12:01 ` Greg KH
2024-11-15 10:51 ` Uwe Kleine-König
2024-11-15 11:01 ` Werner Sembach
2024-11-14 11:50 ` Daniel Gomez
2024-11-20 14:11 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7d97b3d-1880-4c89-bbf2-a742d6ac9e6b@kernel.org \
--to=ukleinek@kernel.org \
--cc=da.gomez@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux@leemhuis.info \
--cc=mcgrof@kernel.org \
--cc=petr.pavlu@suse.com \
--cc=samitolvanen@google.com \
--cc=tux@tuxedocomputers.com \
--cc=wse@tuxedocomputers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome