mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] kgdb: update outdated references to kgdb_wait()
@ 2026-03-21 10:58 Kexin Sun
  2026-03-23  9:53 ` Daniel Thompson
  0 siblings, 1 reply; 3+ messages in thread
From: Kexin Sun @ 2026-03-21 10:58 UTC (permalink / raw)
  To: tglx, mingo, bp, dave.hansen, x86, hpa, jason.wessel, danielt,
	dianders, sohil.mehta, seanjc, xin, linux-kernel, kgdb-bugreport
  Cc: julia.lawall, xutong.ma, kexinsun, yunbolyu, ratnadiraw

The function kgdb_wait() was replaced by kgdb_cpu_enter()
in commit 62fae312197a ("kgdb: eliminate kgdb_wait(), all cpus
enter the same way").  Update the four stale references:
 - include/linux/kgdb.h: kgdb_roundup_cpus() kdoc
 - arch/x86/kernel/kgdb.c: kgdb_roundup_cpus() kdoc; also fix
   pre-existing grammar error ("get them be" -> "get them into")
 - kernel/debug/debug_core.c: inline comment
 - kernel/debug/gdbstub.c: inline comment

Assisted-by: unnamed:deepseek-v3.2 coccinelle
Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
---
 arch/x86/kernel/kgdb.c    | 5 +++--
 include/linux/kgdb.h      | 3 ++-
 kernel/debug/debug_core.c | 2 +-
 kernel/debug/gdbstub.c    | 2 +-
 4 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/arch/x86/kernel/kgdb.c b/arch/x86/kernel/kgdb.c
index 8b1a9733d13e..f50a39818223 100644
--- a/arch/x86/kernel/kgdb.c
+++ b/arch/x86/kernel/kgdb.c
@@ -407,8 +407,9 @@ static void kgdb_disable_hw_debug(struct pt_regs *regs)
  *	kgdb_roundup_cpus - Get other CPUs into a holding pattern
  *
  *	On SMP systems, we need to get the attention of the other CPUs
- *	and get them be in a known state.  This should do what is needed
- *	to get the other CPUs to call kgdb_wait(). Note that on some arches,
+ *	and get them into a known state.  This should do what is needed
+ *	to get the other CPUs to call kgdb_cpu_enter(). Note that on
+ *	some arches,
  *	the NMI approach is not used for rounding up all the CPUs. For example,
  *	in case of MIPS, smp_call_function() is used to roundup CPUs.
  *
diff --git a/include/linux/kgdb.h b/include/linux/kgdb.h
index 22b3f3839f30..bbe9b54a57c9 100644
--- a/include/linux/kgdb.h
+++ b/include/linux/kgdb.h
@@ -202,7 +202,8 @@ extern void kgdb_call_nmi_hook(void *ignored);
  *
  *	On SMP systems, we need to get the attention of the other CPUs
  *	and get them into a known state.  This should do what is needed
- *	to get the other CPUs to call kgdb_wait(). Note that on some arches,
+ *	to get the other CPUs to call kgdb_cpu_enter(). Note that on
+ *	some arches,
  *	the NMI approach is not used for rounding up all the CPUs.  Normally
  *	those architectures can just not implement this and get the default.
  *
diff --git a/kernel/debug/debug_core.c b/kernel/debug/debug_core.c
index 0b9495187fba..1a2f0297a80c 100644
--- a/kernel/debug/debug_core.c
+++ b/kernel/debug/debug_core.c
@@ -704,7 +704,7 @@ static int kgdb_cpu_enter(struct kgdb_state *ks, struct pt_regs *regs,
 	if (ks->send_ready)
 		atomic_set(ks->send_ready, 1);
 
-	/* Signal the other CPUs to enter kgdb_wait() */
+	/* Signal the other CPUs to enter kgdb_cpu_enter() */
 	else if ((!kgdb_single_step) && kgdb_do_roundup)
 		kgdb_roundup_cpus();
 #endif
diff --git a/kernel/debug/gdbstub.c b/kernel/debug/gdbstub.c
index f586afd76c80..aafd8da5d7fc 100644
--- a/kernel/debug/gdbstub.c
+++ b/kernel/debug/gdbstub.c
@@ -517,7 +517,7 @@ static void gdb_get_regs_helper(struct kgdb_state *ks)
 	/*
 	 * All threads that don't have debuggerinfo should be
 	 * in schedule() sleeping, since all other CPUs
-	 * are in kgdb_wait, and thus have debuggerinfo.
+	 * are in kgdb_cpu_enter, and thus have debuggerinfo.
 	 */
 	if (local_debuggerinfo) {
 		pt_regs_to_gdb_regs(gdb_regs, local_debuggerinfo);
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-03-24  3:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-21 10:58 [PATCH] kgdb: update outdated references to kgdb_wait() Kexin Sun
2026-03-23  9:53 ` Daniel Thompson
2026-03-24  3:23   ` [PATCH v2] " Kexin Sun

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®