* [PATCH] media: rc: st_rc: fix reset control resource leak
@ 2025-10-31 6:03 Haotian Zhang
2025-10-31 9:49 ` Patrice CHOTARD
0 siblings, 1 reply; 2+ messages in thread
From: Haotian Zhang @ 2025-10-31 6:03 UTC (permalink / raw)
To: patrice.chotard, sean, mchehab
Cc: linux-arm-kernel, linux-media, linux-kernel, Haotian Zhang
The driver calls reset_control_get_optional_exclusive() but never calls
reset_control_put() in error paths or in the remove function. This causes
a resource leak when probe fails after successfully acquiring the reset
control, or when the driver is unloaded.
Switch to devm_reset_control_get_optional_exclusive() to automatically
manage the reset control resource.
Fixes: a4b80242d046 ("media: st-rc: explicitly request exclusive reset control")
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
---
drivers/media/rc/st_rc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/rc/st_rc.c b/drivers/media/rc/st_rc.c
index 6539fa0a6e79..6b70bac5f45d 100644
--- a/drivers/media/rc/st_rc.c
+++ b/drivers/media/rc/st_rc.c
@@ -284,7 +284,7 @@ static int st_rc_probe(struct platform_device *pdev)
else
rc_dev->rx_base = rc_dev->base;
- rc_dev->rstc = reset_control_get_optional_exclusive(dev, NULL);
+ rc_dev->rstc = devm_reset_control_get_optional_exclusive(dev, NULL);
if (IS_ERR(rc_dev->rstc)) {
ret = PTR_ERR(rc_dev->rstc);
goto err;
--
2.50.1.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] media: rc: st_rc: fix reset control resource leak
2025-10-31 6:03 [PATCH] media: rc: st_rc: fix reset control resource leak Haotian Zhang
@ 2025-10-31 9:49 ` Patrice CHOTARD
0 siblings, 0 replies; 2+ messages in thread
From: Patrice CHOTARD @ 2025-10-31 9:49 UTC (permalink / raw)
To: Haotian Zhang, sean, mchehab; +Cc: linux-arm-kernel, linux-media, linux-kernel
On 10/31/25 07:03, Haotian Zhang wrote:
> The driver calls reset_control_get_optional_exclusive() but never calls
> reset_control_put() in error paths or in the remove function. This causes
> a resource leak when probe fails after successfully acquiring the reset
> control, or when the driver is unloaded.
>
> Switch to devm_reset_control_get_optional_exclusive() to automatically
> manage the reset control resource.
>
> Fixes: a4b80242d046 ("media: st-rc: explicitly request exclusive reset control")
> Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
> ---
> drivers/media/rc/st_rc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/rc/st_rc.c b/drivers/media/rc/st_rc.c
> index 6539fa0a6e79..6b70bac5f45d 100644
> --- a/drivers/media/rc/st_rc.c
> +++ b/drivers/media/rc/st_rc.c
> @@ -284,7 +284,7 @@ static int st_rc_probe(struct platform_device *pdev)
> else
> rc_dev->rx_base = rc_dev->base;
>
> - rc_dev->rstc = reset_control_get_optional_exclusive(dev, NULL);
> + rc_dev->rstc = devm_reset_control_get_optional_exclusive(dev, NULL);
> if (IS_ERR(rc_dev->rstc)) {
> ret = PTR_ERR(rc_dev->rstc);
> goto err;
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Thanks
Patrice
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-31 9:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-31 6:03 [PATCH] media: rc: st_rc: fix reset control resource leak Haotian Zhang
2025-10-31 9:49 ` Patrice CHOTARD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®