From: Stefan Wahren <stefan.wahren@i2se.com>
To: David Miller <davem@davemloft.net>
Cc: gregkh@linuxfoundation.org, jslaby@suse.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 net-next 8/8] net: qualcomm: add QCA7000 UART driver
Date: Fri, 21 Oct 2016 13:38:17 +0200 [thread overview]
Message-ID: <acda56ec-75c2-9753-710e-d69b36f88095@i2se.com> (raw)
In-Reply-To: <20161018.143025.284251297276702898.davem@davemloft.net>
Am 18.10.2016 um 20:30 schrieb David Miller:
> From: Stefan Wahren <stefan.wahren@i2se.com>
> Date: Tue, 18 Oct 2016 13:27:34 +0200
>
>> +void
>> +qca_tty_receive(struct tty_struct *tty, const unsigned char *cp, char *fp,
>> + int count)
>> +{
>> + struct qcauart *qca = tty->disc_data;
>> + struct net_device_stats *n_stats = &qca->net_dev->stats;
>> + int dropped = 0;
> Please order local variable declarations from longest to shortest line.
Even if the current second init depends on the first one?
prev parent reply other threads:[~2016-10-21 11:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 11:27 [PATCH v3 net-next 0/8] " Stefan Wahren
2016-10-18 11:27 ` [PATCH v3 net-next 1/8] net: qualcomm: remove unnecessary includes Stefan Wahren
2016-10-18 11:27 ` [PATCH v3 net-next 2/8] net: qca_debug: use net_device_ops instead of direct call Stefan Wahren
2016-10-18 11:27 ` [PATCH v3 net-next 3/8] net: qualcomm: move qcaspi_tx_cmd to qca_spi.c Stefan Wahren
2016-10-18 18:28 ` David Miller
2016-10-18 11:27 ` [PATCH v3 net-next 4/8] net: qualcomm: rename qca_framing.c to qca_common.c Stefan Wahren
2016-10-18 11:40 ` Greg Kroah-Hartman
2016-10-18 11:27 ` [PATCH v3 net-next 5/8] net: qualcomm: move MTU handling to qca_common Stefan Wahren
2016-10-18 18:29 ` David Miller
2016-10-18 11:27 ` [PATCH v3 net-next 6/8] net: qualcomm: prepare frame decoding for UART driver Stefan Wahren
2016-10-18 11:27 ` [PATCH v3 net-next 7/8] net: qualcomm: make qca_common a separate kernel module Stefan Wahren
2016-10-18 11:27 ` [PATCH v3 net-next 8/8] net: qualcomm: add QCA7000 UART driver Stefan Wahren
2016-10-18 18:30 ` David Miller
2016-10-21 11:38 ` Stefan Wahren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acda56ec-75c2-9753-710e-d69b36f88095@i2se.com \
--to=stefan.wahren@i2se.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®