* [PATCH] xen/pvcalls: fix null pointer dereference on map->sock
@ 2018-02-22 17:22 Colin King
2018-02-22 19:19 ` Juergen Gross
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2018-02-22 17:22 UTC (permalink / raw)
To: Boris Ostrovsky, Juergen Gross, xen-devel; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Currently if map is null then a potential null pointer deference
occurs when calling sock_release on map->sock. I believe the
actual intention was to call sock_release on sock instead. Fix
this.
Fixes: 5db4d286a8ef ("xen/pvcalls: implement connect command")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/xen/pvcalls-back.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
index 156e5aea36db..b1092fbefa63 100644
--- a/drivers/xen/pvcalls-back.c
+++ b/drivers/xen/pvcalls-back.c
@@ -416,7 +416,7 @@ static int pvcalls_back_connect(struct xenbus_device *dev,
sock);
if (!map) {
ret = -EFAULT;
- sock_release(map->sock);
+ sock_release(sock);
}
out:
--
2.15.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] xen/pvcalls: fix null pointer dereference on map->sock
2018-02-22 17:22 [PATCH] xen/pvcalls: fix null pointer dereference on map->sock Colin King
@ 2018-02-22 19:19 ` Juergen Gross
0 siblings, 0 replies; 2+ messages in thread
From: Juergen Gross @ 2018-02-22 19:19 UTC (permalink / raw)
To: Colin King, Boris Ostrovsky, xen-devel; +Cc: kernel-janitors, linux-kernel
On 22/02/18 18:22, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently if map is null then a potential null pointer deference
> occurs when calling sock_release on map->sock. I believe the
> actual intention was to call sock_release on sock instead. Fix
> this.
>
> Fixes: 5db4d286a8ef ("xen/pvcalls: implement connect command")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Hmm, yes, kind of obvious. :-)
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-22 19:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-22 17:22 [PATCH] xen/pvcalls: fix null pointer dereference on map->sock Colin King
2018-02-22 19:19 ` Juergen Gross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®