mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH next 4/5] minmax: Allow comparisons of 'int' against 'unsigned char/short'.
@ 2023-07-25 10:00 David Laight
  0 siblings, 0 replies; only message in thread
From: David Laight @ 2023-07-25 10:00 UTC (permalink / raw)
  To: linux-kernel, 'Andy Shevchenko', 'Andrew Morton',
	Matthew Wilcox (Oracle),
	Christoph Hellwig, Jason A. Donenfeld

Since 'unsigned char/short' get promoted to 'signed int' it is
safe to compare them against an 'int' value.

Signed-off-by: David Laight <david.laight@aculab.com>
---
 include/linux/minmax.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/linux/minmax.h b/include/linux/minmax.h
index 179034479d5e..baffbe5c855d 100644
--- a/include/linux/minmax.h
+++ b/include/linux/minmax.h
@@ -16,7 +16,8 @@
  *   allocation usage).
  */
 #define __types_ok(x, y) \
-	(is_signed_type(typeof(x)) == is_signed_type(typeof(y)))
+	(is_signed_type(typeof(x)) == is_signed_type(typeof(y)) ||	\
+		is_signed_type(typeof((x) + 0)) == is_signed_type(typeof((y) + 0)))
 
 #define __cmp_op_min <
 #define __cmp_op_max >
-- 
2.17.1

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-07-25 10:01 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-25 10:00 [PATCH next 4/5] minmax: Allow comparisons of 'int' against 'unsigned char/short' David Laight

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®