mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Rob Herring <robh@kernel.org>, Herve Codina <herve.codina@bootlin.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the reset tree
Date: Fri, 25 Oct 2024 16:46:54 +0200	[thread overview]
Message-ID: <ad2a190a1f93edb787478ed3433b154b9753f7c8.camel@pengutronix.de> (raw)
In-Reply-To: <CAL_JsqLvUygPQYhsaCuRjwPXJrKR9sASWWLvrSTsBdR44SBbuA@mail.gmail.com>

On Fr, 2024-10-25 at 08:44 -0500, Rob Herring wrote:
> On Fri, Oct 25, 2024 at 1:28 AM Herve Codina <herve.codina@bootlin.com> wrote:
> > 
> > Hi all,
> > 
> > On Fri, 25 Oct 2024 11:09:19 +1100
> > Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > 
> > > Hi all,
> > > 
> > > After merging the reset tree, today's linux-next build (x86_64
> > > allmodconfig) produced this warning:
> > > 
> > > drivers/misc/lan966x_pci.dtso:34.23-40.7: Warning (interrupts_property): /fragment@0/__overlay__/pci-ep-bus@0/oic@e00c0120: Missing interrupt-parent
> > > 
> > > Introduced by commit
> > > 
> > >   185686beb464 ("misc: Add support for LAN966x PCI device")
> > > 
> > 
> > This warning is normal.
> > interrupt-parent is not present in the oic node. This was discussed in
> > https://lore.kernel.org/all/CAL_Jsq+je7+9ATR=B6jXHjEJHjn24vQFs4Tvi9=vhDeK9n42Aw@mail.gmail.com/
> 
> We can't have warnings especially in things outside of arch/. Doesn't
> matter why.
> 
> The choices to fix are:
> 
> - Override DTC_FLAGS in drivers/misc/. You can set DTC_FLAGS_lan966x_pci
> 
> - Disable the check in dtc for overlays. We've done this for other cases.
> 
> - Add enough info into the overlay to avoid the warnings. This might
> mean the overlay has to be applied up one node level. It is
> duplicating a few things which are in the base tree. This is my
> preference because it makes the overlay stand on its own. We'll have
> the same issue with dtschema checks too if we don't do this.

I see four more warnings that look like false positives to me:

drivers/misc/lan966x_pci.dtso:42.22-46.7: Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/cpu_clk: missing or empty reg/ranges property
drivers/misc/lan966x_pci.dtso:48.22-52.7: Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/ddr_clk: missing or empty reg/ranges property
drivers/misc/lan966x_pci.dtso:54.22-58.7: Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/sys_clk: missing or empty reg/ranges property
drivers/misc/lan966x_pci.dtso:18.15-165.5: Warning (avoid_unnecessary_addr_size): /fragment@0/__overlay__: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property

Setting

DTC_FLAGS_lan966x_pci := -Wno-interrupts_property -Wno-simple_bus_reg -Wno-avoid_unnecessary_addr_size

silences them all.

regards
Philipp

      reply	other threads:[~2024-10-25 14:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-25  0:09 Stephen Rothwell
2024-10-25  6:28 ` Herve Codina
2024-10-25 13:44   ` Rob Herring
2024-10-25 14:46     ` Philipp Zabel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad2a190a1f93edb787478ed3433b154b9753f7c8.camel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=herve.codina@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®