* [PATCH] drm/msm/mdp5: drop workarounds specific to MDP5 1.0
@ 2026-03-25 3:06 Dmitry Baryshkov
2026-03-25 8:59 ` Konrad Dybcio
2026-04-06 23:42 ` Dmitry Baryshkov
0 siblings, 2 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2026-03-25 3:06 UTC (permalink / raw)
To: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, David Airlie, Simona Vetter
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel
With support for MSM8974v1 being removed from the driver, there is no
need to keep workarounds specific to that particular MDP5 revision. Drop
them, slightly simplifying the logic.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c
index 500b7dc895d0..890d2f31510e 100644
--- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c
+++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c
@@ -118,8 +118,6 @@ uint32_t mdp5_smp_calculate(struct mdp5_smp *smp,
u32 width, bool hdecim)
{
const struct drm_format_info *info = drm_format_info(format->pixel_format);
- struct mdp5_kms *mdp5_kms = get_kms(smp);
- int rev = mdp5_cfg_get_hw_rev(mdp5_kms->cfg);
int i, hsub, nplanes, nlines;
uint32_t blkcfg = 0;
@@ -133,7 +131,7 @@ uint32_t mdp5_smp_calculate(struct mdp5_smp *smp,
* U and V components (splits them from Y if necessary) and packs
* them together, writes to SMP using a single client.
*/
- if ((rev > 0) && (format->chroma_sample > CHROMA_FULL)) {
+ if (format->chroma_sample > CHROMA_FULL) {
nplanes = 2;
/* if decimation is enabled, HW decimates less on the
@@ -151,10 +149,6 @@ uint32_t mdp5_smp_calculate(struct mdp5_smp *smp,
n = DIV_ROUND_UP(fetch_stride * nlines, smp->blk_size);
- /* for hw rev v1.00 */
- if (rev == 0)
- n = roundup_pow_of_two(n);
-
blkcfg |= (n << (8 * i));
}
---
base-commit: 6efced27f5df9d7a57e4847fe2898cdd19f72311
change-id: 20260325-mdp5-further-drop-mdp1-0-f9dbe9fc7eed
prerequisite-change-id: 20260302-topic-goodnight_8974v1-c1eaab4aa08c:v1
prerequisite-patch-id: 7b71df892e1f8548f0f2b7345560edb17df5d5a6
Best regards,
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/msm/mdp5: drop workarounds specific to MDP5 1.0
2026-03-25 3:06 [PATCH] drm/msm/mdp5: drop workarounds specific to MDP5 1.0 Dmitry Baryshkov
@ 2026-03-25 8:59 ` Konrad Dybcio
2026-04-06 23:42 ` Dmitry Baryshkov
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2026-03-25 8:59 UTC (permalink / raw)
To: Dmitry Baryshkov, Rob Clark, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Sean Paul, Marijn Suijten, David Airlie,
Simona Vetter
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel
On 3/25/26 4:06 AM, Dmitry Baryshkov wrote:
> With support for MSM8974v1 being removed from the driver, there is no
> need to keep workarounds specific to that particular MDP5 revision. Drop
> them, slightly simplifying the logic.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/msm/mdp5: drop workarounds specific to MDP5 1.0
2026-03-25 3:06 [PATCH] drm/msm/mdp5: drop workarounds specific to MDP5 1.0 Dmitry Baryshkov
2026-03-25 8:59 ` Konrad Dybcio
@ 2026-04-06 23:42 ` Dmitry Baryshkov
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2026-04-06 23:42 UTC (permalink / raw)
To: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, David Airlie, Simona Vetter,
Dmitry Baryshkov
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel
On Wed, 25 Mar 2026 05:06:06 +0200, Dmitry Baryshkov wrote:
> With support for MSM8974v1 being removed from the driver, there is no
> need to keep workarounds specific to that particular MDP5 revision. Drop
> them, slightly simplifying the logic.
Applied to msm-next, thanks!
[1/1] drm/msm/mdp5: drop workarounds specific to MDP5 1.0
https://gitlab.freedesktop.org/lumag/msm/-/commit/e224e3a167bc
Best regards,
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-06 23:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-25 3:06 [PATCH] drm/msm/mdp5: drop workarounds specific to MDP5 1.0 Dmitry Baryshkov
2026-03-25 8:59 ` Konrad Dybcio
2026-04-06 23:42 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®