From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Zhaoyang Yu <23120469@bjtu.edu.cn>
Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org,
kees@kernel.org, fourier.thomas@gmail.com,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
gszhai@bjtu.edu.cn, 2426767509@qq.com
Subject: Re: [PATCH] tty: serial: pch_uart: add check for dma_alloc_coherent()
Date: Wed, 8 Apr 2026 16:22:35 +0300 [thread overview]
Message-ID: <adZWm7GxCU_-T0zc@ashevche-desk.local> (raw)
In-Reply-To: <20260408072421.831-1-23120469@bjtu.edu.cn>
On Wed, Apr 08, 2026 at 03:24:21PM +0800, Zhaoyang Yu wrote:
> Add a check for dma_alloc_coherent() failure to prevent a potential
> NULL pointer dereference in dma_handle_rx(). Properly release DMA
> channels and the PCI device reference using a goto ladder if the
> allocation fails.
Looks like it deserves a Fixes tag.
Also ideally this driver should be converted to one of 8250 cases.
The latter has already DMA support. Note, if you are going this
direction, I have the hardware to test.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-08 13:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 7:24 Zhaoyang Yu
2026-04-08 13:22 ` Andy Shevchenko [this message]
2026-04-09 5:46 ` 俞朝阳
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adZWm7GxCU_-T0zc@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=23120469@bjtu.edu.cn \
--cc=2426767509@qq.com \
--cc=fourier.thomas@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gszhai@bjtu.edu.cn \
--cc=jirislaby@kernel.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®