From: 俞朝阳 <2426767509@qq.com>
To: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>
Cc: gregkh <gregkh@linuxfoundation.org>,
jirislaby <jirislaby@kernel.org>, kees <kees@kernel.org>,
"fourier.thomas" <fourier.thomas@gmail.com>,
linux-serial <linux-serial@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
gszhai <gszhai@bjtu.edu.cn>, "Zhaoyang Yu" <23120469@bjtu.edu.cn>
Subject: Re: [PATCH] tty: serial: pch_uart: add check for dma_alloc_coherent()
Date: Thu, 9 Apr 2026 13:46:50 +0800 [thread overview]
Message-ID: <tencent_7753BD5DA5FC7F7BB722609FA158ACC5F50A@qq.com> (raw)
In-Reply-To: <adZWm7GxCU_-T0zc@ashevche-desk.local>
Hi Andy,
Thank you for the review and the suggestions!
> Looks like it deserves a Fixes tag.
Agreed. I will find the original commit that introduced this issue and add the proper Fixes tag in the v2 patch. I'll send it out shortly.
> Also ideally this driver should be converted to one of 8250 cases.
> The latter has already DMA support. Note, if you are going this
> direction, I have the hardware to test.
Thank you very much for offering to test on the actual hardware! That is incredibly helpful.
I agree that converting this driver to the 8250 framework is the right direction. Since that would be a larger refactoring effort, I think it might be best to apply this quick NULL pointer fix first so that the current driver is safe.
After this fix is settled, I am very interested in taking a look at the 8250 conversion as a follow-up project. I might need some time to study the 8250 DMA framework, but I will definitely reach out with a patch series for you to test when I get there!
Best regards,
Zhaoyang Yu
prev parent reply other threads:[~2026-04-09 5:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 7:24 Zhaoyang Yu
2026-04-08 13:22 ` Andy Shevchenko
2026-04-09 5:46 ` 俞朝阳 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_7753BD5DA5FC7F7BB722609FA158ACC5F50A@qq.com \
--to=2426767509@qq.com \
--cc=23120469@bjtu.edu.cn \
--cc=andriy.shevchenko@linux.intel.com \
--cc=fourier.thomas@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gszhai@bjtu.edu.cn \
--cc=jirislaby@kernel.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®