linux-next: infiniband tree build failure

linux-next: infiniband tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 347 bytes --]

Hi all,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

ERROR: ".__ipv6_addr_type" [drivers/infiniband/core/rdma_cm.ko] undefined!

I have used the version of the infiniband tree from next-20091119 for
today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: infiniband tree build failure

[Roland Dreier]

 > Today's linux-next build (powerpc ppc64_defconfig) failed like this:
 > 
 > ERROR: ".__ipv6_addr_type" [drivers/infiniband/core/rdma_cm.ko] undefined!
 > 
 > I have used the version of the infiniband tree from next-20091119 for
 > today.

Sorry, will track it down.  Sean this probably came from your patches,
any idea off the top of your head?

RE: linux-next: infiniband tree build failure

[Sean Hefty]

>Sorry, will track it down.  Sean this probably came from your patches,
>any idea off the top of your head?

Off the top of my head, I'll guess that maybe we need to add something like

#if defined(CONFIG_IPv6) || defined(CONFIG_IPV6_MODULE)

to cma_check_linklocal() in cma.c.  Does this build failure occur when IPv6 is
excluded?

- Sean

Re: linux-next: infiniband tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 638 bytes --]

Hi Roland, Sean,

On Thu, 19 Nov 2009 16:19:29 -0800 Roland Dreier <rdreier@cisco.com> wrote:
>
> 
>  > Today's linux-next build (powerpc ppc64_defconfig) failed like this:
>  > 
>  > ERROR: ".__ipv6_addr_type" [drivers/infiniband/core/rdma_cm.ko] undefined!
>  > 
>  > I have used the version of the infiniband tree from next-20091119 for
>  > today.
> 
> Sorry, will track it down.  Sean this probably came from your patches,
> any idea off the top of your head?

Big hint:  IPV6 is not enabled in this config.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: infiniband tree build failure

[Roland Dreier]

 > Off the top of my head, I'll guess that maybe we need to add something like

 > #if defined(CONFIG_IPv6) || defined(CONFIG_IPV6_MODULE)

Yes, makes sense, I'll throw that in.

 - R.

Re: linux-next: infiniband tree build failure

[Roland Dreier]

OK, so I threw this into the ipv6 patch, I think it's right:

diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
index 71e616a..fbdd731 100644
--- a/drivers/infiniband/core/cma.c
+++ b/drivers/infiniband/core/cma.c
@@ -2083,6 +2083,7 @@ static int cma_get_port(struct rdma_id_private *id_priv)
 static int cma_check_linklocal(struct rdma_dev_addr *dev_addr,
 			       struct sockaddr *addr)
 {
+#if defined(CONFIG_IPv6) || defined(CONFIG_IPV6_MODULE)
 	struct sockaddr_in6 *sin6;
 
 	if (addr->sa_family != AF_INET6)
@@ -2094,6 +2095,7 @@ static int cma_check_linklocal(struct rdma_dev_addr *dev_addr,
 			return -EINVAL;
 
 	dev_addr->bound_dev_if = sin6->sin6_scope_id;
+#endif
 	return 0;
 }
 

RE: linux-next: infiniband tree build failure

[Sean Hefty]

>OK, so I threw this into the ipv6 patch, I think it's right:

Looks correct - thanks.

>diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
>index 71e616a..fbdd731 100644
>--- a/drivers/infiniband/core/cma.c
>+++ b/drivers/infiniband/core/cma.c
>@@ -2083,6 +2083,7 @@ static int cma_get_port(struct rdma_id_private *id_priv)
> static int cma_check_linklocal(struct rdma_dev_addr *dev_addr,
> 			       struct sockaddr *addr)
> {
>+#if defined(CONFIG_IPv6) || defined(CONFIG_IPV6_MODULE)
> 	struct sockaddr_in6 *sin6;
>
> 	if (addr->sa_family != AF_INET6)
>@@ -2094,6 +2095,7 @@ static int cma_check_linklocal(struct rdma_dev_addr
>*dev_addr,
> 			return -EINVAL;
>
> 	dev_addr->bound_dev_if = sin6->sin6_scope_id;
>+#endif
> 	return 0;
> }
>