* [PATCH] ib/ehca: bitmask handling for lock_hcalls
@ 2010-06-10 9:06 Alexander Schmidt
2010-06-11 16:02 ` Roland Dreier
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Schmidt @ 2010-06-10 9:06 UTC (permalink / raw)
To: Roland Dreier, Linux RDMA
Cc: lkml, Stefan Roscher, Joachim Fenkes, Christoph Raisch, Hoang-Nam Nguyen
Fix reading capability bit from device capabilities for hcall locking.
Signed-off-by: Alexander Schmidt <alexs@linux.vnet.ibm.com>
---
Hi Roland, this applies against 2.6.35-rc2 and we would like to get
it into your -next tree, thanks!
drivers/infiniband/hw/ehca/ehca_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- linux-2.6.35-rc2.orig/drivers/infiniband/hw/ehca/ehca_main.c
+++ linux-2.6.35-rc2/drivers/infiniband/hw/ehca/ehca_main.c
@@ -360,7 +360,8 @@ static int ehca_sense_attributes(struct
* a firmware property, so it's valid across all adapters
*/
if (ehca_lock_hcalls == -1)
- ehca_lock_hcalls = !(shca->hca_cap & HCA_CAP_H_ALLOC_RES_SYNC);
+ ehca_lock_hcalls = !EHCA_BMASK_GET(HCA_CAP_H_ALLOC_RES_SYNC,
+ shca->hca_cap);
/* translate supported MR page sizes; always support 4K */
shca->hca_cap_mr_pgsize = EHCA_PAGESIZE;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ib/ehca: bitmask handling for lock_hcalls
2010-06-10 9:06 [PATCH] ib/ehca: bitmask handling for lock_hcalls Alexander Schmidt
@ 2010-06-11 16:02 ` Roland Dreier
2010-06-14 8:05 ` Alexander Schmidt
0 siblings, 1 reply; 3+ messages in thread
From: Roland Dreier @ 2010-06-11 16:02 UTC (permalink / raw)
To: Alexander Schmidt
Cc: Linux RDMA, lkml, Stefan Roscher, Joachim Fenkes,
Christoph Raisch, Hoang-Nam Nguyen
What is the impact of this problem? ie is this something we need to fix
for 2.6.35? I suppose not, since the current code has been there a long time.
--
Roland Dreier <rolandd@cisco.com> || For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ib/ehca: bitmask handling for lock_hcalls
2010-06-11 16:02 ` Roland Dreier
@ 2010-06-14 8:05 ` Alexander Schmidt
0 siblings, 0 replies; 3+ messages in thread
From: Alexander Schmidt @ 2010-06-14 8:05 UTC (permalink / raw)
To: Roland Dreier
Cc: Linux RDMA, lkml, Stefan Roscher, Joachim Fenkes,
Christoph Raisch, Hoang-Nam Nguyen
On Fri, 11 Jun 2010 09:02:43 -0700
Roland Dreier <rdreier@cisco.com> wrote:
> What is the impact of this problem? ie is this something we need to fix
> for 2.6.35? I suppose not, since the current code has been there a long time.
Right, we are okay with integrating this into 2.6.36, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-06-14 8:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-06-10 9:06 [PATCH] ib/ehca: bitmask handling for lock_hcalls Alexander Schmidt
2010-06-11 16:02 ` Roland Dreier
2010-06-14 8:05 ` Alexander Schmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®