mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dinh Nguyen <dinguyen@kernel.org>
To: genevieve.chan@altera.com,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Ang Tien Sung <tien.sung.ang@intel.com>,
	linux-kernel@vger.kernel.org
Cc: Tze Yee Ng <tze.yee.ng@altera.com>,
	Adrian Ng Ho Yin <adrian.ho.yin.ng@altera.com>,
	Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>,
	Hang Suan Wang <hang.suan.wang@altera.com>
Subject: Re: [PATCH v3] firmware: stratix10-svc: fix FCS SMC call kernel-doc
Date: Mon, 6 Jul 2026 08:56:56 -0500	[thread overview]
Message-ID: <adb96baa-49a4-494c-be16-f8926226d84e@kernel.org> (raw)
In-Reply-To: <20260706055541.74783-1-genevieve.chan@altera.com>



On 7/6/26 00:55, genevieve.chan@altera.com wrote:
> From: Genevieve Chan <genevieve.chan@altera.com>
> 
> Correct kernel-doc errors for two FCS SMC calls:
> 
> INTEL_SIP_SMC_FCS_SEND_CERTIFICATE:
> - Describe as async to match STD_CALL_VAL usage
> - Replace INTEL_SIP_SMC_FCS_REJECTED with INTEL_SIP_SMC_REJECTED
> 
> INTEL_SIP_SMC_FCS_GET_PROVISION_DATA:
> - Replace FCS-specific status macros with standard status macros
>    (INTEL_SIP_SMC_STATUS_ERROR and INTEL_SIP_SMC_STATUS_REJECTED)
> - Restore return register documentation for a1 (mailbox error),
>    a2 (physical address), and a3 (structure size)
> 
> Fixes: 4a4709d470e6 ("firmware: stratix10-svc: add new FCS commands")
> Fixes: 4b0a32016347 ("firmware: stratix10-svc: change get provision data to async SMC call")

I see how this patch fixes 4a4709d470e6 but I don't see how this patch 
fixes 4b0a32016347. Can you justify how it fixes the second commit?

Thanks,
Dinh

  reply	other threads:[~2026-07-06 13:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-06  5:55 genevieve.chan
2026-07-06 13:56 ` Dinh Nguyen [this message]
2026-07-07  5:02   ` Chan, Genevieve
2026-07-09 15:39     ` Dinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adb96baa-49a4-494c-be16-f8926226d84e@kernel.org \
    --to=dinguyen@kernel.org \
    --cc=adrian.ho.yin.ng@altera.com \
    --cc=genevieve.chan@altera.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hang.suan.wang@altera.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=muhammad.nazim.amirul.nazle.asmade@altera.com \
    --cc=tien.sung.ang@intel.com \
    --cc=tze.yee.ng@altera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®