Re: [PATCH v3] firmware: stratix10-svc: fix FCS SMC call kernel-doc

["Chan, Genevieve" <genevieve.chan@altera.com>]

On 6/7/2026 9:56 pm, Dinh Nguyen wrote:
> 
> 
> On 7/6/26 00:55, genevieve.chan@altera.com wrote:
>> From: Genevieve Chan <genevieve.chan@altera.com>
>>
>> Correct kernel-doc errors for two FCS SMC calls:
>>
>> INTEL_SIP_SMC_FCS_SEND_CERTIFICATE:
>> - Describe as async to match STD_CALL_VAL usage
>> - Replace INTEL_SIP_SMC_FCS_REJECTED with INTEL_SIP_SMC_REJECTED
>>
>> INTEL_SIP_SMC_FCS_GET_PROVISION_DATA:
>> - Replace FCS-specific status macros with standard status macros
>>    (INTEL_SIP_SMC_STATUS_ERROR and INTEL_SIP_SMC_STATUS_REJECTED)
>> - Restore return register documentation for a1 (mailbox error),
>>    a2 (physical address), and a3 (structure size)
>>
>> Fixes: 4a4709d470e6 ("firmware: stratix10-svc: add new FCS commands")
>> Fixes: 4b0a32016347 ("firmware: stratix10-svc: change get provision data to async SMC call")
> 
> I see how this patch fixes 4a4709d470e6 but I don't see how this patch fixes 4b0a32016347. Can you justify how it fixes the second commit?

Hi Dinh,

The fixes for 4b0a32016347 includes modifying the original macro definition description section for register a1-a3 as well as the return status description of the INTEL_SIP_SMC_FCS_GET_PROVISION_DATA cmd.

Thanks,
Genevieve Chan

> 
> Thanks,
> Dinh