mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] riscv: dead code cleanup in kconfig for RISCV_PROBE_VECTOR_UNALIGNED_ACCESS
@ 2026-03-29 20:32 Julian Braha
  2026-03-31 13:03 ` Jesse T
  2026-05-22 23:51 ` Paul Walmsley
  0 siblings, 2 replies; 3+ messages in thread
From: Julian Braha @ 2026-03-29 20:32 UTC (permalink / raw)
  To: charlie, mr.bossman075, palmer, alexghiti
  Cc: pjw, aou, linux-riscv, linux-kernel, Julian Braha

The same Kconfig statement 'depends on RISCV_ISA_V' appears twice for
RISCV_PROBE_VECTOR_UNALIGNED_ACCESS. The first instance is in its choice
menu, "Vector unaligned Accesses Support", making the second instance in
its specific Kconfig definition dead code. I propose removing this second
instance.

This dead code was found by kconfirm, a static analysis tool for Kconfig.

Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
 arch/riscv/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
index 61a9d8d3ea64..35a2926494e1 100644
--- a/arch/riscv/Kconfig
+++ b/arch/riscv/Kconfig
@@ -1004,7 +1004,6 @@ choice
 config RISCV_PROBE_VECTOR_UNALIGNED_ACCESS
 	bool "Probe speed of vector unaligned accesses"
 	select RISCV_VECTOR_MISALIGNED
-	depends on RISCV_ISA_V
 	help
 	  During boot, the kernel will run a series of tests to determine the
 	  speed of vector unaligned accesses if they are supported. This probing
-- 
2.51.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] riscv: dead code cleanup in kconfig for RISCV_PROBE_VECTOR_UNALIGNED_ACCESS
  2026-03-29 20:32 [PATCH] riscv: dead code cleanup in kconfig for RISCV_PROBE_VECTOR_UNALIGNED_ACCESS Julian Braha
@ 2026-03-31 13:03 ` Jesse T
  2026-05-22 23:51 ` Paul Walmsley
  1 sibling, 0 replies; 3+ messages in thread
From: Jesse T @ 2026-03-31 13:03 UTC (permalink / raw)
  To: Julian Braha
  Cc: charlie, palmer, alexghiti, pjw, aou, linux-riscv, linux-kernel

On Sun, Mar 29, 2026 at 4:32 PM Julian Braha <julianbraha@gmail.com> wrote:
>
> The same Kconfig statement 'depends on RISCV_ISA_V' appears twice for
> RISCV_PROBE_VECTOR_UNALIGNED_ACCESS. The first instance is in its choice
> menu, "Vector unaligned Accesses Support", making the second instance in
> its specific Kconfig definition dead code. I propose removing this second
> instance.
>
> This dead code was found by kconfirm, a static analysis tool for Kconfig.
>
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
Reviewed-by: Jesse Taube <mr.bossman075@gmail.com>

Thanks,
Jesse Taube

> ---
>  arch/riscv/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index 61a9d8d3ea64..35a2926494e1 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -1004,7 +1004,6 @@ choice
>  config RISCV_PROBE_VECTOR_UNALIGNED_ACCESS
>         bool "Probe speed of vector unaligned accesses"
>         select RISCV_VECTOR_MISALIGNED
> -       depends on RISCV_ISA_V
>         help
>           During boot, the kernel will run a series of tests to determine the
>           speed of vector unaligned accesses if they are supported. This probing
> --
> 2.51.2
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] riscv: dead code cleanup in kconfig for RISCV_PROBE_VECTOR_UNALIGNED_ACCESS
  2026-03-29 20:32 [PATCH] riscv: dead code cleanup in kconfig for RISCV_PROBE_VECTOR_UNALIGNED_ACCESS Julian Braha
  2026-03-31 13:03 ` Jesse T
@ 2026-05-22 23:51 ` Paul Walmsley
  1 sibling, 0 replies; 3+ messages in thread
From: Paul Walmsley @ 2026-05-22 23:51 UTC (permalink / raw)
  To: Julian Braha
  Cc: charlie, mr.bossman075, palmer, alexghiti, pjw, aou, linux-riscv,
	linux-kernel

On Sun, 29 Mar 2026, Julian Braha wrote:

> The same Kconfig statement 'depends on RISCV_ISA_V' appears twice for
> RISCV_PROBE_VECTOR_UNALIGNED_ACCESS. The first instance is in its choice
> menu, "Vector unaligned Accesses Support", making the second instance in
> its specific Kconfig definition dead code. I propose removing this second
> instance.
> 
> This dead code was found by kconfirm, a static analysis tool for Kconfig.
> 
> Signed-off-by: Julian Braha <julianbraha@gmail.com>

Thanks, queued for v7.2.

- Paul


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-05-22 23:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-29 20:32 [PATCH] riscv: dead code cleanup in kconfig for RISCV_PROBE_VECTOR_UNALIGNED_ACCESS Julian Braha
2026-03-31 13:03 ` Jesse T
2026-05-22 23:51 ` Paul Walmsley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®