From: "Arnd Bergmann" <arnd@arndb.de>
To: Yeking@red54.com, linux-staging@lists.linux.dev
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Philipp Hortmann" <philipp.g.hortmann@gmail.com>,
"Masahiro Yamada" <masahiroy@kernel.org>,
"Nicolas Schier" <nicolas@fjasle.eu>,
"Hans de Goede" <hdegoede@redhat.com>,
"Rodrigo Gobbi" <rodrigo.gobbi.7@gmail.com>,
"Dan Carpenter" <dan.carpenter@linaro.org>,
"Justin Stitt" <justinstitt@google.com>,
"Johannes Berg" <johannes.berg@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: Remove ioctl interface
Date: Thu, 09 Jan 2025 22:19:40 +0100 [thread overview]
Message-ID: <aeadd5b3-c187-4800-ac1f-fe2b53bfb3f7@app.fastmail.com> (raw)
In-Reply-To: <tencent_E4A835D41FF1F35C7BDFCF4EA0136D548F06@qq.com>
On Thu, Jan 9, 2025, at 14:20, Yeking@red54.com wrote:
> From: 谢致邦 (XIE Zhibang) <Yeking@Red54.com>
>
> Wireless drivers should not use the ioctl interface, so remove this
> interface for the rtl8723bs driver. (found by code inspection)
>
> Fixes: 8bfb36766064 ("wireless: wext: remove ndo_do_ioctl fallback")
> Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver")
> Signed-off-by: 谢致邦 (XIE Zhibang) <Yeking@Red54.com>
> ---
> drivers/staging/rtl8723bs/Makefile | 1 -
> .../staging/rtl8723bs/include/osdep_intf.h | 2 -
> .../staging/rtl8723bs/os_dep/ioctl_linux.c | 1286 -----------------
> drivers/staging/rtl8723bs/os_dep/os_intfs.c | 1 -
> 4 files changed, 1290 deletions(-)
> delete mode 100644 drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
Thanks for picking this up again. I had done a complete removal
of ndo_do_ioctl a while ago but hadn't gotten around to finishing
the upstreaming. For my older patches, see
https://lore.kernel.org/all/20231009141908.1767241-7-arnd@kernel.org/
Your version is very similar but seems to miss a couple of stale
data structure and function declarations. Can you make sure you
include all those?
Arnd
next prev parent reply other threads:[~2025-01-09 21:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 13:20 Yeking
2025-01-09 20:31 ` Philipp Hortmann
2025-01-09 21:19 ` Arnd Bergmann [this message]
2025-01-10 13:10 ` Yeking
2025-02-22 19:03 ` [PATCH] staging: rtl8723bs: Remove some unused functions, macros, and structs Yeking
2025-02-24 8:53 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeadd5b3-c187-4800-ac1f-fe2b53bfb3f7@app.fastmail.com \
--to=arnd@arndb.de \
--cc=Yeking@red54.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=johannes.berg@intel.com \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=philipp.g.hortmann@gmail.com \
--cc=rodrigo.gobbi.7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®