From: Yeking@Red54.com
To: arnd@arndb.de
Cc: Yeking@red54.com, dan.carpenter@linaro.org,
gregkh@linuxfoundation.org, hdegoede@redhat.com,
johannes.berg@intel.com, justinstitt@google.com,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
masahiroy@kernel.org, nicolas@fjasle.eu,
philipp.g.hortmann@gmail.com, rodrigo.gobbi.7@gmail.com
Subject: Re: Re: [PATCH] staging: rtl8723bs: Remove ioctl interface
Date: Fri, 10 Jan 2025 13:10:23 +0000 [thread overview]
Message-ID: <tencent_202D558F9075C15FCD33573BC88F48E03706@qq.com> (raw)
In-Reply-To: <aeadd5b3-c187-4800-ac1f-fe2b53bfb3f7@app.fastmail.com>
> Thanks for picking this up again. I had done a complete removal
> of ndo_do_ioctl a while ago but hadn't gotten around to finishing
> the upstreaming. For my older patches, see
> https://lore.kernel.org/all/20231009141908.1767241-7-arnd@kernel.org/
>
> Your version is very similar but seems to miss a couple of stale
> data structure and function declarations. Can you make sure you
> include all those?
>
> Arnd
Thanks for letting me know that you have an old patch. The stale functions like
rtw_ndev_notifier_call, rtw_ndev_notifier_register and
rtw_ndev_notifier_unregister, and the related struct rtw_ndev_notifier have
been removed in 037f9a6df3fb (staging: rtl8723bs: Remove no-op
netdevice_notifier(), 2024-10-24). As for the intf_priv struct that was removed
in your old patch, it has not been processed yet, because rtl8723bs has a lot
of such structs that have not been used since they were introduced in
554c0a3abf21 (staging: Add rtl8723bs sdio wifi driver, 2017-03-29), such as
many in rtw_mp.h. I plan to deal with these contents later.
XIE Zhibang
next prev parent reply other threads:[~2025-01-10 13:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 13:20 Yeking
2025-01-09 20:31 ` Philipp Hortmann
2025-01-09 21:19 ` Arnd Bergmann
2025-01-10 13:10 ` Yeking [this message]
2025-02-22 19:03 ` [PATCH] staging: rtl8723bs: Remove some unused functions, macros, and structs Yeking
2025-02-24 8:53 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_202D558F9075C15FCD33573BC88F48E03706@qq.com \
--to=yeking@red54.com \
--cc=arnd@arndb.de \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=johannes.berg@intel.com \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=philipp.g.hortmann@gmail.com \
--cc=rodrigo.gobbi.7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®