mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Magnus Damm" <magnus.damm@gmail.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: "Andi Kleen" <ak@suse.de>, "Magnus Damm" <magnus@valinux.co.jp>,
	fastboot@lists.osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [Fastboot] [PATCH] x86_64: Reload CS when startup_64 is used.
Date: Tue, 22 Aug 2006 17:53:26 +0900	[thread overview]
Message-ID: <aec7e5c30608220153h4553d890v3a3740e7fdc6986@mail.gmail.com> (raw)
In-Reply-To: <m1y7thqi7b.fsf_-_@ebiederm.dsl.xmission.com>

Hi Eric,

On 8/22/06, Eric W. Biederman <ebiederm@xmission.com> wrote:
>
> In long mode the %cs is largely a relic.  However there are a few cases
> like lret where it matters that we have a valid value.  Without this
> patch it is possible to enter the kernel in startup_64 without setting
> %cs to a valid value.  With this patch we don't care what %cs value
> we enter the kernel with, so long as the cs shadow register indicates
> it is a privileged code segment.
>
> Thanks to Magnus Damm for finding this problem and posting the
> first workable patch.  I have moved the jump to set %cs down a
> few instructions so we don't need to take an extra jump.  Which
> keeps the code simpler.
>
> Signed-of-by: Eric W. Biederman <ebiederm@xmission.com>

While at it, could you please fix up the purgatory code in kexec-tools
to include this fix so we can boot older versions of the kernel too?

Thanks,

/ magnus

  reply	other threads:[~2006-08-22  8:53 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-21  9:54 [PATCH][RFC] " Magnus Damm
2006-08-21 10:19 ` Andi Kleen
2006-08-21 13:29   ` [Fastboot] " Magnus Damm
2006-08-21 14:16     ` Andi Kleen
2006-08-22  0:47       ` Magnus Damm
2006-08-21 14:17     ` Vivek Goyal
2006-08-21 14:24       ` Andi Kleen
2006-08-21 14:46         ` Vivek Goyal
2006-08-21 15:04           ` Andi Kleen
2006-08-21 20:02             ` Eric W. Biederman
2006-08-21 20:10               ` Andi Kleen
2006-08-21 21:00                 ` Eric W. Biederman
2006-08-21 21:02 ` Eric W. Biederman
2006-08-22  0:58   ` Magnus Damm
2006-08-22  3:41     ` Eric W. Biederman
2006-08-22  4:10       ` Magnus Damm
2006-08-22  8:03       ` Andi Kleen
2006-08-22  8:37         ` [PATCH] " Eric W. Biederman
2006-08-22  8:53           ` Magnus Damm [this message]
2006-08-22  9:25             ` [Fastboot] " Eric W. Biederman
2006-08-23  3:10               ` Magnus Damm
2006-08-22  9:01           ` Andi Kleen
2006-08-22  9:20             ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aec7e5c30608220153h4553d890v3a3740e7fdc6986@mail.gmail.com \
    --to=magnus.damm@gmail.com \
    --cc=ak@suse.de \
    --cc=ebiederm@xmission.com \
    --cc=fastboot@lists.osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=magnus@valinux.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®