From: "Magnus Damm" <magnus.damm@gmail.com>
To: "Uwe Kleine-König" <Uwe.Kleine-Koenig@digi.com>
Cc: "Paul Mundt" <lethal@linux-sh.org>,
"Hans J. Koch" <hjk@linutronix.de>,
linux-kernel@vger.kernel.org, gregkh@suse.de,
akpm@linux-foundation.org, tglx@linutronix.de
Subject: Re: [PATCH] uio_pdrv: Unique IRQ Mode
Date: Tue, 10 Jun 2008 13:40:42 +0900 [thread overview]
Message-ID: <aec7e5c30806092140s21cc8cbdtbaf69f864dd2bda7@mail.gmail.com> (raw)
In-Reply-To: <20080609123406.GB27803@digi.com>
Hi Uwe,
Thanks for your help.
On Mon, Jun 9, 2008 at 9:34 PM, Uwe Kleine-König
<Uwe.Kleine-Koenig@digi.com> wrote:
> Paul Mundt wrote:
>> [...] the constructive way forward
>> seems to be to follow Uwe's suggestions and respin the patch.
> Just to let you know: I'm willing to look on a new version. And I like
> "User IRQ Mode".
Sure, let's go with that name then.
But shall we really go down the path with separate exported functions?
I think we discussed that earlier. Why I'm asking is that this adds
extra complexity - function prototypes in header files,
EXPORT_SYMBOL() stuff and more lines of code needed for each driver
instance.
Isn't it enough to add a kconfig option for CONFIG_UIO_PDRV_USER_IRQ
which depends on CONFIG_SUPERH (if we really want that) and wrap the
code in CONFIG_UIO_PDRV_USER_IRQ?
Let me know what you want and I'll respin the patch. Thanks!
/ magnus
next prev parent reply other threads:[~2008-06-10 4:40 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-04 6:08 Magnus Damm
2008-06-04 10:11 ` Hans J. Koch
2008-06-05 1:25 ` Magnus Damm
2008-06-05 6:49 ` Uwe Kleine-König
2008-06-06 2:55 ` Magnus Damm
2008-06-06 10:04 ` Hans J. Koch
2008-06-08 10:03 ` Magnus Damm
2008-06-05 9:09 ` Hans J. Koch
2008-06-05 9:46 ` Magnus Damm
2008-06-05 11:27 ` Hans J. Koch
2008-06-08 10:19 ` Magnus Damm
2008-06-08 20:54 ` Hans J. Koch
2008-06-09 1:12 ` Magnus Damm
2008-06-09 8:44 ` Hans J. Koch
2008-06-09 9:01 ` Paul Mundt
2008-06-09 12:34 ` Uwe Kleine-König
2008-06-10 3:12 ` Greg KH
2008-06-10 4:40 ` Magnus Damm [this message]
2008-06-10 7:10 ` Uwe Kleine-König
2008-06-10 7:14 ` [PATCH] UIO: minor style and comment fixes Uwe Kleine-König
2008-06-10 9:07 ` Hans J. Koch
2008-06-10 13:50 ` [PATCH] uio_pdrv: Unique IRQ Mode Magnus Damm
2008-06-10 17:32 ` Paul Mundt
2008-06-10 19:24 ` Uwe Kleine-König
2008-06-09 4:09 ` Paul Mundt
2008-06-09 7:57 ` Uwe Kleine-König
2008-06-09 8:00 ` Paul Mundt
2008-06-09 9:54 ` Hans J. Koch
2008-06-09 12:32 ` Uwe Kleine-König
2008-06-09 14:20 ` Hans J. Koch
2008-06-10 6:11 ` Uwe Kleine-König
2008-06-10 9:01 ` Hans J. Koch
2008-06-05 11:33 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aec7e5c30806092140s21cc8cbdtbaf69f864dd2bda7@mail.gmail.com \
--to=magnus.damm@gmail.com \
--cc=Uwe.Kleine-Koenig@digi.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=hjk@linutronix.de \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®