mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Magnus Damm" <magnus.damm@gmail.com>
To: "Uwe Kleine-König" <Uwe.Kleine-Koenig@digi.com>
Cc: "Paul Mundt" <lethal@linux-sh.org>,
	"Hans J. Koch" <hjk@linutronix.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"gregkh@suse.de" <gregkh@suse.de>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"tglx@linutronix.de" <tglx@linutronix.de>
Subject: Re: [PATCH] uio_pdrv: Unique IRQ Mode
Date: Tue, 10 Jun 2008 22:50:46 +0900	[thread overview]
Message-ID: <aec7e5c30806100650m41089e1p4b487837b6271471@mail.gmail.com> (raw)
In-Reply-To: <20080610071032.GB22814@digi.com>

On Tue, Jun 10, 2008 at 4:10 PM, Uwe Kleine-König
<Uwe.Kleine-Koenig@digi.com> wrote:
> I think you can implement the handler and irqcontrol functions static
> inline.  Then the need to statically compile uio goes away.  And if all
> uio_pdrv devices are registered in the same .c file you don't even have
> a (binary) size penalty.

Good idea, that's nice and clean.

>> Let me know what you want and I'll respin the patch. Thanks!
> ... I started describing in detail my suggestion, but actually it's
> easier to do the patch myself.  So here it comes.  Note it's not even
> compile tested, but you should be able to get my intentions.

Excellent! I wrote some code to export the VEU in sh7722 on top of
your patch and things work just fine. Slightly more structure members
to fill in with this approach, but that's fine. This less automatic
approach hopefully causes less confusion. =)

> From: Uwe Kleine-König <Uwe.Kleine-Koenig@digi.com>
> Date: Tue, 10 Jun 2008 09:06:24 +0200
> Subject: [PATCH] UIO: wip
>
> Signed-off-by: Uwe Kleine-König <Uwe.Kleine-Koenig@digi.com>

Acked-by: Magnus Damm <damm@igel.co.jp>

Thanks for your help!

/ magnus

  parent reply	other threads:[~2008-06-10 13:51 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-04  6:08 Magnus Damm
2008-06-04 10:11 ` Hans J. Koch
2008-06-05  1:25   ` Magnus Damm
2008-06-05  6:49     ` Uwe Kleine-König
2008-06-06  2:55       ` Magnus Damm
2008-06-06 10:04         ` Hans J. Koch
2008-06-08 10:03           ` Magnus Damm
2008-06-05  9:09     ` Hans J. Koch
2008-06-05  9:46       ` Magnus Damm
2008-06-05 11:27         ` Hans J. Koch
2008-06-08 10:19           ` Magnus Damm
2008-06-08 20:54             ` Hans J. Koch
2008-06-09  1:12               ` Magnus Damm
2008-06-09  8:44                 ` Hans J. Koch
2008-06-09  9:01                   ` Paul Mundt
2008-06-09 12:34                     ` Uwe Kleine-König
2008-06-10  3:12                       ` Greg KH
2008-06-10  4:40                       ` Magnus Damm
2008-06-10  7:10                         ` Uwe Kleine-König
2008-06-10  7:14                           ` [PATCH] UIO: minor style and comment fixes Uwe Kleine-König
2008-06-10  9:07                             ` Hans J. Koch
2008-06-10 13:50                           ` Magnus Damm [this message]
2008-06-10 17:32                           ` [PATCH] uio_pdrv: Unique IRQ Mode Paul Mundt
2008-06-10 19:24                             ` Uwe Kleine-König
2008-06-09  4:09               ` Paul Mundt
2008-06-09  7:57               ` Uwe Kleine-König
2008-06-09  8:00                 ` Paul Mundt
2008-06-09  9:54                 ` Hans J. Koch
2008-06-09 12:32                   ` Uwe Kleine-König
2008-06-09 14:20                     ` Hans J. Koch
2008-06-10  6:11                       ` Uwe Kleine-König
2008-06-10  9:01                         ` Hans J. Koch
2008-06-05 11:33         ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aec7e5c30806100650m41089e1p4b487837b6271471@mail.gmail.com \
    --to=magnus.damm@gmail.com \
    --cc=Uwe.Kleine-Koenig@digi.com \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@suse.de \
    --cc=hjk@linutronix.de \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®