* [PATCH] thermal: k3_j72xx_bandgap: Fix the debug print message
@ 2022-10-10 3:41 Keerthy
2022-10-17 7:32 ` Daniel Lezcano
0 siblings, 1 reply; 4+ messages in thread
From: Keerthy @ 2022-10-10 3:41 UTC (permalink / raw)
To: daniel.lezcano, rui.zhang, amitk; +Cc: j-keerthy, bb, linux-pm, linux-kernel
The debug print message to check the workaround applicability is inverted.
Fix the same.
Fixes: ffcb2fc86eb7 ("thermal: k3_j72xx_bandgap: Add the bandgap driver support")
Reported-by: Bryan Brattlof <bb@ti.com>
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
drivers/thermal/k3_j72xx_bandgap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/k3_j72xx_bandgap.c b/drivers/thermal/k3_j72xx_bandgap.c
index 16b6bcf1bf4f..c073b1023bbe 100644
--- a/drivers/thermal/k3_j72xx_bandgap.c
+++ b/drivers/thermal/k3_j72xx_bandgap.c
@@ -439,7 +439,7 @@ static int k3_j72xx_bandgap_probe(struct platform_device *pdev)
workaround_needed = false;
dev_dbg(bgp->dev, "Work around %sneeded\n",
- workaround_needed ? "not " : "");
+ workaround_needed ? "" : "not ");
if (!workaround_needed)
init_table(5, ref_table, golden_factors);
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] thermal: k3_j72xx_bandgap: Fix the debug print message
2022-10-10 3:41 [PATCH] thermal: k3_j72xx_bandgap: Fix the debug print message Keerthy
@ 2022-10-17 7:32 ` Daniel Lezcano
2022-10-17 7:38 ` J, KEERTHY
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Lezcano @ 2022-10-17 7:32 UTC (permalink / raw)
To: Keerthy, rui.zhang, amitk; +Cc: bb, linux-pm, linux-kernel
On 10/10/2022 05:41, Keerthy wrote:
> The debug print message to check the workaround applicability is inverted.
> Fix the same.
>
> Fixes: ffcb2fc86eb7 ("thermal: k3_j72xx_bandgap: Add the bandgap driver support")
> Reported-by: Bryan Brattlof <bb@ti.com>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
Applied, thanks
BTW, Kheerty, if you have time is it possible to convert the
k3_bandgap.c with the pre-computed factors like the k3_j72xx_bandgap.c,
so both can be merged ?
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] thermal: k3_j72xx_bandgap: Fix the debug print message
2022-10-17 7:32 ` Daniel Lezcano
@ 2022-10-17 7:38 ` J, KEERTHY
2022-10-17 7:39 ` Daniel Lezcano
0 siblings, 1 reply; 4+ messages in thread
From: J, KEERTHY @ 2022-10-17 7:38 UTC (permalink / raw)
To: Daniel Lezcano, rui.zhang, amitk; +Cc: bb, linux-pm, linux-kernel
On 10/17/2022 1:02 PM, Daniel Lezcano wrote:
> On 10/10/2022 05:41, Keerthy wrote:
>> The debug print message to check the workaround applicability is
>> inverted.
>> Fix the same.
>>
>> Fixes: ffcb2fc86eb7 ("thermal: k3_j72xx_bandgap: Add the bandgap
>> driver support")
>> Reported-by: Bryan Brattlof <bb@ti.com>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>
> Applied, thanks
>
> BTW, Kheerty, if you have time is it possible to convert the
> k3_bandgap.c with the pre-computed factors like the k3_j72xx_bandgap.c,
> so both can be merged ?
Okay. I will try that out in a couple of weeks time.
Thanks,
Keerthy
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] thermal: k3_j72xx_bandgap: Fix the debug print message
2022-10-17 7:38 ` J, KEERTHY
@ 2022-10-17 7:39 ` Daniel Lezcano
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Lezcano @ 2022-10-17 7:39 UTC (permalink / raw)
To: J, KEERTHY, rui.zhang, amitk; +Cc: bb, linux-pm, linux-kernel
On 17/10/2022 09:38, J, KEERTHY wrote:
>
>
> On 10/17/2022 1:02 PM, Daniel Lezcano wrote:
>> On 10/10/2022 05:41, Keerthy wrote:
>>> The debug print message to check the workaround applicability is
>>> inverted.
>>> Fix the same.
>>>
>>> Fixes: ffcb2fc86eb7 ("thermal: k3_j72xx_bandgap: Add the bandgap
>>> driver support")
>>> Reported-by: Bryan Brattlof <bb@ti.com>
>>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>>> ---
>>
>> Applied, thanks
>>
>> BTW, Kheerty, if you have time is it possible to convert the
>> k3_bandgap.c with the pre-computed factors like the
>> k3_j72xx_bandgap.c, so both can be merged ?
>
> Okay. I will try that out in a couple of weeks time.
Great, thanks!
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-17 7:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-10 3:41 [PATCH] thermal: k3_j72xx_bandgap: Fix the debug print message Keerthy
2022-10-17 7:32 ` Daniel Lezcano
2022-10-17 7:38 ` J, KEERTHY
2022-10-17 7:39 ` Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®