mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mario Limonciello <superm1@kernel.org>
To: Lizhi Hou <lizhi.hou@amd.com>,
	ogabbay@kernel.org, quic_jhugo@quicinc.com,
	dri-devel@lists.freedesktop.org, karol.wachowski@linux.intel.com,
	max.zhen@amd.com
Cc: linux-kernel@vger.kernel.org, sonal.santan@amd.com
Subject: Re: [PATCH V2] accel/amdxdna: Add support for AIE2 revision 9
Date: Tue, 29 Sep 2026 13:24:47 -0500	[thread overview]
Message-ID: <aee76270-590d-4d2b-93ca-23e56bc3f482@kernel.org> (raw)
In-Reply-To: <20260929181459.928468-1-lizhi.hou@amd.com>



On 9/29/26 13:14, Lizhi Hou wrote:
> aie2_get_dev_revision() fails to recognize AIE2 revision 9 hardware.
> Add AIE2_DEV_REVISION_GRGH to the list of supported AIE2 revisions.
> 
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>> ---
> V2:
>    Fix sashiko comment: add the revision string.
> 
>   drivers/accel/amdxdna/aie2_msg_priv.h | 1 +
>   drivers/accel/amdxdna/npu4_regs.c     | 1 +
>   2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/accel/amdxdna/aie2_msg_priv.h b/drivers/accel/amdxdna/aie2_msg_priv.h
> index fd65a4236d49..8ed2b5701dcc 100644
> --- a/drivers/accel/amdxdna/aie2_msg_priv.h
> +++ b/drivers/accel/amdxdna/aie2_msg_priv.h
> @@ -530,6 +530,7 @@ enum aie2_dev_revision {
>   	AIE2_DEV_REVISION_GPT1,
>   	AIE2_DEV_REVISION_GPT2,
>   	AIE2_DEV_REVISION_GPT3,
> +	AIE2_DEV_REVISION_GRGH,
>   	AIE2_DEV_REVISION_UNKN,
>   };
>   
> diff --git a/drivers/accel/amdxdna/npu4_regs.c b/drivers/accel/amdxdna/npu4_regs.c
> index 15a161384625..c9648c8032ec 100644
> --- a/drivers/accel/amdxdna/npu4_regs.c
> +++ b/drivers/accel/amdxdna/npu4_regs.c
> @@ -153,6 +153,7 @@ const struct amdxdna_rev_vbnv npu4_rev_vbnv_tbl[] = {
>   	{ AIE2_DEV_REVISION_GPT1, "NPU Gorgon Point 1" },
>   	{ AIE2_DEV_REVISION_GPT2, "NPU Gorgon Point 2" },
>   	{ AIE2_DEV_REVISION_GPT3, "NPU Gorgon Point 3" },
> +	{ AIE2_DEV_REVISION_GRGH, "NPU Gorgon Halo" },
>   	{ 0 }
>   };
>   


  reply	other threads:[~2026-09-29 18:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29 18:14 Lizhi Hou
2026-09-29 18:24 ` Mario Limonciello [this message]
2026-09-29 18:41   ` Lizhi Hou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aee76270-590d-4d2b-93ca-23e56bc3f482@kernel.org \
    --to=superm1@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=karol.wachowski@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizhi.hou@amd.com \
    --cc=max.zhen@amd.com \
    --cc=ogabbay@kernel.org \
    --cc=quic_jhugo@quicinc.com \
    --cc=sonal.santan@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®