* [PATCH V2] accel/amdxdna: Add support for AIE2 revision 9
@ 2026-09-29 18:14 Lizhi Hou
2026-09-29 18:24 ` Mario Limonciello
0 siblings, 1 reply; 3+ messages in thread
From: Lizhi Hou @ 2026-09-29 18:14 UTC (permalink / raw)
To: ogabbay, quic_jhugo, dri-devel, mario.limonciello,
karol.wachowski, max.zhen
Cc: Lizhi Hou, linux-kernel, sonal.santan
aie2_get_dev_revision() fails to recognize AIE2 revision 9 hardware.
Add AIE2_DEV_REVISION_GRGH to the list of supported AIE2 revisions.
Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
---
V2:
Fix sashiko comment: add the revision string.
drivers/accel/amdxdna/aie2_msg_priv.h | 1 +
drivers/accel/amdxdna/npu4_regs.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/accel/amdxdna/aie2_msg_priv.h b/drivers/accel/amdxdna/aie2_msg_priv.h
index fd65a4236d49..8ed2b5701dcc 100644
--- a/drivers/accel/amdxdna/aie2_msg_priv.h
+++ b/drivers/accel/amdxdna/aie2_msg_priv.h
@@ -530,6 +530,7 @@ enum aie2_dev_revision {
AIE2_DEV_REVISION_GPT1,
AIE2_DEV_REVISION_GPT2,
AIE2_DEV_REVISION_GPT3,
+ AIE2_DEV_REVISION_GRGH,
AIE2_DEV_REVISION_UNKN,
};
diff --git a/drivers/accel/amdxdna/npu4_regs.c b/drivers/accel/amdxdna/npu4_regs.c
index 15a161384625..c9648c8032ec 100644
--- a/drivers/accel/amdxdna/npu4_regs.c
+++ b/drivers/accel/amdxdna/npu4_regs.c
@@ -153,6 +153,7 @@ const struct amdxdna_rev_vbnv npu4_rev_vbnv_tbl[] = {
{ AIE2_DEV_REVISION_GPT1, "NPU Gorgon Point 1" },
{ AIE2_DEV_REVISION_GPT2, "NPU Gorgon Point 2" },
{ AIE2_DEV_REVISION_GPT3, "NPU Gorgon Point 3" },
+ { AIE2_DEV_REVISION_GRGH, "NPU Gorgon Halo" },
{ 0 }
};
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V2] accel/amdxdna: Add support for AIE2 revision 9
2026-09-29 18:14 [PATCH V2] accel/amdxdna: Add support for AIE2 revision 9 Lizhi Hou
@ 2026-09-29 18:24 ` Mario Limonciello
2026-09-29 18:41 ` Lizhi Hou
0 siblings, 1 reply; 3+ messages in thread
From: Mario Limonciello @ 2026-09-29 18:24 UTC (permalink / raw)
To: Lizhi Hou, ogabbay, quic_jhugo, dri-devel, karol.wachowski, max.zhen
Cc: linux-kernel, sonal.santan
On 9/29/26 13:14, Lizhi Hou wrote:
> aie2_get_dev_revision() fails to recognize AIE2 revision 9 hardware.
> Add AIE2_DEV_REVISION_GRGH to the list of supported AIE2 revisions.
>
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>> ---
> V2:
> Fix sashiko comment: add the revision string.
>
> drivers/accel/amdxdna/aie2_msg_priv.h | 1 +
> drivers/accel/amdxdna/npu4_regs.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/accel/amdxdna/aie2_msg_priv.h b/drivers/accel/amdxdna/aie2_msg_priv.h
> index fd65a4236d49..8ed2b5701dcc 100644
> --- a/drivers/accel/amdxdna/aie2_msg_priv.h
> +++ b/drivers/accel/amdxdna/aie2_msg_priv.h
> @@ -530,6 +530,7 @@ enum aie2_dev_revision {
> AIE2_DEV_REVISION_GPT1,
> AIE2_DEV_REVISION_GPT2,
> AIE2_DEV_REVISION_GPT3,
> + AIE2_DEV_REVISION_GRGH,
> AIE2_DEV_REVISION_UNKN,
> };
>
> diff --git a/drivers/accel/amdxdna/npu4_regs.c b/drivers/accel/amdxdna/npu4_regs.c
> index 15a161384625..c9648c8032ec 100644
> --- a/drivers/accel/amdxdna/npu4_regs.c
> +++ b/drivers/accel/amdxdna/npu4_regs.c
> @@ -153,6 +153,7 @@ const struct amdxdna_rev_vbnv npu4_rev_vbnv_tbl[] = {
> { AIE2_DEV_REVISION_GPT1, "NPU Gorgon Point 1" },
> { AIE2_DEV_REVISION_GPT2, "NPU Gorgon Point 2" },
> { AIE2_DEV_REVISION_GPT3, "NPU Gorgon Point 3" },
> + { AIE2_DEV_REVISION_GRGH, "NPU Gorgon Halo" },
> { 0 }
> };
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V2] accel/amdxdna: Add support for AIE2 revision 9
2026-09-29 18:24 ` Mario Limonciello
@ 2026-09-29 18:41 ` Lizhi Hou
0 siblings, 0 replies; 3+ messages in thread
From: Lizhi Hou @ 2026-09-29 18:41 UTC (permalink / raw)
To: Mario Limonciello, ogabbay, quic_jhugo, dri-devel,
karol.wachowski, max.zhen
Cc: linux-kernel, sonal.santan
Applied to drm-misc-next
On 9/29/26 11:24, Mario Limonciello wrote:
>
>
> On 9/29/26 13:14, Lizhi Hou wrote:
>> aie2_get_dev_revision() fails to recognize AIE2 revision 9 hardware.
>> Add AIE2_DEV_REVISION_GRGH to the list of supported AIE2 revisions.
>>
>> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
> Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>> ---
>> V2:
>> Fix sashiko comment: add the revision string.
>>
>> drivers/accel/amdxdna/aie2_msg_priv.h | 1 +
>> drivers/accel/amdxdna/npu4_regs.c | 1 +
>> 2 files changed, 2 insertions(+)
>>
>> diff --git a/drivers/accel/amdxdna/aie2_msg_priv.h
>> b/drivers/accel/amdxdna/aie2_msg_priv.h
>> index fd65a4236d49..8ed2b5701dcc 100644
>> --- a/drivers/accel/amdxdna/aie2_msg_priv.h
>> +++ b/drivers/accel/amdxdna/aie2_msg_priv.h
>> @@ -530,6 +530,7 @@ enum aie2_dev_revision {
>> AIE2_DEV_REVISION_GPT1,
>> AIE2_DEV_REVISION_GPT2,
>> AIE2_DEV_REVISION_GPT3,
>> + AIE2_DEV_REVISION_GRGH,
>> AIE2_DEV_REVISION_UNKN,
>> };
>> diff --git a/drivers/accel/amdxdna/npu4_regs.c
>> b/drivers/accel/amdxdna/npu4_regs.c
>> index 15a161384625..c9648c8032ec 100644
>> --- a/drivers/accel/amdxdna/npu4_regs.c
>> +++ b/drivers/accel/amdxdna/npu4_regs.c
>> @@ -153,6 +153,7 @@ const struct amdxdna_rev_vbnv npu4_rev_vbnv_tbl[]
>> = {
>> { AIE2_DEV_REVISION_GPT1, "NPU Gorgon Point 1" },
>> { AIE2_DEV_REVISION_GPT2, "NPU Gorgon Point 2" },
>> { AIE2_DEV_REVISION_GPT3, "NPU Gorgon Point 3" },
>> + { AIE2_DEV_REVISION_GRGH, "NPU Gorgon Halo" },
>> { 0 }
>> };
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-09-29 18:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-29 18:14 [PATCH V2] accel/amdxdna: Add support for AIE2 revision 9 Lizhi Hou
2026-09-29 18:24 ` Mario Limonciello
2026-09-29 18:41 ` Lizhi Hou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®