From: Guenter Roeck <linux@roeck-us.net>
To: Qianfeng Rong <rongqianfeng@vivo.com>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (nct6775) Use int type to store negative error codes
Date: Sun, 31 Aug 2025 15:24:53 -0700 [thread overview]
Message-ID: <aefc0a7e-e697-465a-96bc-0d700f16a3cf@roeck-us.net> (raw)
In-Reply-To: <20250830095105.3271-1-rongqianfeng@vivo.com>
On Sat, Aug 30, 2025 at 05:51:05PM +0800, Qianfeng Rong wrote:
> Change the 'ret' variable from u32 to int in nct6775_asuswmi_read() to
> store negative error codes or zero;
>
> Storing the negative error codes in unsigned type, doesn't cause an issue
> at runtime but can be confusing. Additionally, assigning negative error
> codes to unsigned type may trigger a GCC warning when the -Wsign-conversion
> flag is enabled.
>
> No effect on runtime.
>
> Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Applied.
Guenter
prev parent reply other threads:[~2025-08-31 22:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-30 9:51 Qianfeng Rong
2025-08-31 22:24 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aefc0a7e-e697-465a-96bc-0d700f16a3cf@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rongqianfeng@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®