* [PATCH] hwmon: (nct6775) Use int type to store negative error codes
@ 2025-08-30 9:51 Qianfeng Rong
2025-08-31 22:24 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Qianfeng Rong @ 2025-08-30 9:51 UTC (permalink / raw)
To: Guenter Roeck, linux-hwmon, linux-kernel; +Cc: Qianfeng Rong
Change the 'ret' variable from u32 to int in nct6775_asuswmi_read() to
store negative error codes or zero;
Storing the negative error codes in unsigned type, doesn't cause an issue
at runtime but can be confusing. Additionally, assigning negative error
codes to unsigned type may trigger a GCC warning when the -Wsign-conversion
flag is enabled.
No effect on runtime.
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
---
drivers/hwmon/nct6775-platform.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/hwmon/nct6775-platform.c b/drivers/hwmon/nct6775-platform.c
index 0a040364b512..407945d2cd6a 100644
--- a/drivers/hwmon/nct6775-platform.c
+++ b/drivers/hwmon/nct6775-platform.c
@@ -167,7 +167,8 @@ static inline int nct6775_asuswmi_write(u8 bank, u8 reg, u8 val)
static inline int nct6775_asuswmi_read(u8 bank, u8 reg, u8 *val)
{
- u32 ret, tmp = 0;
+ u32 tmp = 0;
+ int ret;
ret = nct6775_asuswmi_evaluate_method(ASUSWMI_METHODID_RHWM, bank,
reg, 0, &tmp);
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] hwmon: (nct6775) Use int type to store negative error codes
2025-08-30 9:51 [PATCH] hwmon: (nct6775) Use int type to store negative error codes Qianfeng Rong
@ 2025-08-31 22:24 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2025-08-31 22:24 UTC (permalink / raw)
To: Qianfeng Rong; +Cc: linux-hwmon, linux-kernel
On Sat, Aug 30, 2025 at 05:51:05PM +0800, Qianfeng Rong wrote:
> Change the 'ret' variable from u32 to int in nct6775_asuswmi_read() to
> store negative error codes or zero;
>
> Storing the negative error codes in unsigned type, doesn't cause an issue
> at runtime but can be confusing. Additionally, assigning negative error
> codes to unsigned type may trigger a GCC warning when the -Wsign-conversion
> flag is enabled.
>
> No effect on runtime.
>
> Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Applied.
Guenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-31 22:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-30 9:51 [PATCH] hwmon: (nct6775) Use int type to store negative error codes Qianfeng Rong
2025-08-31 22:24 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®