From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Linmao Li <lilinmao@kylinos.cn>
Cc: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>,
"Liam Girdwood" <liam.r.girdwood@linux.intel.com>,
"Peter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
"Bard Liao" <yung-chuan.liao@linux.intel.com>,
"Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
"Pierre-Louis Bossart" <pierre-louis.bossart@linux.dev>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
"Mark Brown" <broonie@kernel.org>
Subject: Re: [PATCH] ASoC: Intel: avs: da7219: Remove redundant DAI link name allocation
Date: Thu, 23 Jul 2026 12:35:17 +0200 [thread overview]
Message-ID: <af0860aa-2060-454b-a5f6-241f760bbc61@intel.com> (raw)
In-Reply-To: <20260723093639.2364360-1-lilinmao@kylinos.cn>
On 7/23/2026 11:36 AM, Linmao Li wrote:
> avs_create_dai_link() assigns dl->name twice; the first devm_kasprintf()
> is immediately overwritten by the TDM-aware name. Drop the redundant
> first assignment.
>
> Signed-off-by: Linmao Li <lilinmao@kylinos.cn>
> ---
> sound/soc/intel/avs/boards/da7219.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/intel/avs/boards/da7219.c b/sound/soc/intel/avs/boards/da7219.c
> index 2b17abcbd2bc..6cc8a6618fa1 100644
> --- a/sound/soc/intel/avs/boards/da7219.c
> +++ b/sound/soc/intel/avs/boards/da7219.c
> @@ -175,7 +175,6 @@ static int avs_create_dai_link(struct device *dev, int ssp_port, int tdm_slot,
> if (!dl || !platform)
> return -ENOMEM;
>
> - dl->name = devm_kasprintf(dev, GFP_KERNEL, "SSP%d-Codec", ssp_port);
> dl->name = devm_kasprintf(dev, GFP_KERNEL,
> AVS_STRING_FMT("SSP", "-Codec", ssp_port, tdm_slot));
> dl->cpus = devm_kzalloc(dev, sizeof(*dl->cpus), GFP_KERNEL);
FWIW I've scanned the series [1] which introduced the issue. Looks like
this is the only offending line. Thank you for addressing it:
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
[1]:
https://lore.kernel.org/all/20231012083514.492626-1-amadeuszx.slawinski@linux.intel.com/
next prev parent reply other threads:[~2026-07-23 10:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 9:36 Linmao Li
2026-07-23 10:35 ` Cezary Rojewski [this message]
2026-07-26 20:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af0860aa-2060-454b-a5f6-241f760bbc61@intel.com \
--to=cezary.rojewski@intel.com \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=lilinmao@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®