[PATCH] ASoC: Intel: avs: da7219: Remove redundant DAI link name allocation

[PATCH] ASoC: Intel: avs: da7219: Remove redundant DAI link name allocation

[Linmao Li]

avs_create_dai_link() assigns dl->name twice; the first devm_kasprintf()
is immediately overwritten by the TDM-aware name. Drop the redundant
first assignment.

Signed-off-by: Linmao Li <lilinmao@kylinos.cn>
---
 sound/soc/intel/avs/boards/da7219.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/intel/avs/boards/da7219.c b/sound/soc/intel/avs/boards/da7219.c
index 2b17abcbd2bc..6cc8a6618fa1 100644
--- a/sound/soc/intel/avs/boards/da7219.c
+++ b/sound/soc/intel/avs/boards/da7219.c
@@ -175,7 +175,6 @@ static int avs_create_dai_link(struct device *dev, int ssp_port, int tdm_slot,
 	if (!dl || !platform)
 		return -ENOMEM;
 
-	dl->name = devm_kasprintf(dev, GFP_KERNEL, "SSP%d-Codec", ssp_port);
 	dl->name = devm_kasprintf(dev, GFP_KERNEL,
 				  AVS_STRING_FMT("SSP", "-Codec", ssp_port, tdm_slot));
 	dl->cpus = devm_kzalloc(dev, sizeof(*dl->cpus), GFP_KERNEL);
-- 
2.25.1

Re: [PATCH] ASoC: Intel: avs: da7219: Remove redundant DAI link name allocation

[Cezary Rojewski]

On 7/23/2026 11:36 AM, Linmao Li wrote:
> avs_create_dai_link() assigns dl->name twice; the first devm_kasprintf()
> is immediately overwritten by the TDM-aware name. Drop the redundant
> first assignment.
> 
> Signed-off-by: Linmao Li <lilinmao@kylinos.cn>
> ---
>   sound/soc/intel/avs/boards/da7219.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/sound/soc/intel/avs/boards/da7219.c b/sound/soc/intel/avs/boards/da7219.c
> index 2b17abcbd2bc..6cc8a6618fa1 100644
> --- a/sound/soc/intel/avs/boards/da7219.c
> +++ b/sound/soc/intel/avs/boards/da7219.c
> @@ -175,7 +175,6 @@ static int avs_create_dai_link(struct device *dev, int ssp_port, int tdm_slot,
>   	if (!dl || !platform)
>   		return -ENOMEM;
>   
> -	dl->name = devm_kasprintf(dev, GFP_KERNEL, "SSP%d-Codec", ssp_port);
>   	dl->name = devm_kasprintf(dev, GFP_KERNEL,
>   				  AVS_STRING_FMT("SSP", "-Codec", ssp_port, tdm_slot));
>   	dl->cpus = devm_kzalloc(dev, sizeof(*dl->cpus), GFP_KERNEL);

FWIW I've scanned the series [1] which introduced the issue. Looks like 
this is the only offending line. Thank you for addressing it:

Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>


[1]: 
https://lore.kernel.org/all/20231012083514.492626-1-amadeuszx.slawinski@linux.intel.com/

Re: [PATCH] ASoC: Intel: avs: da7219: Remove redundant DAI link name allocation

[Mark Brown]

On Thu, 23 Jul 2026 17:36:39 +0800, Linmao Li wrote:
> ASoC: Intel: avs: da7219: Remove redundant DAI link name allocation

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.3

Thanks!

[1/1] ASoC: Intel: avs: da7219: Remove redundant DAI link name allocation
      https://git.kernel.org/broonie/sound/c/7859b74c0bd6

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark