From: "Simmons, James A." <simmonsja@ornl.gov>
To: "'Nilesh Kokane'" <nilesh.kokane05@gmail.com>,
"oleg.drokin@intel.com" <oleg.drokin@intel.com>,
"andreas.dilger@intel.com" <andreas.dilger@intel.com>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"suneel.raikar@gmail.com" <suneel.raikar@gmail.com>
Subject: RE: [PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno should typically be negative (ie: return -EAGAIN)
Date: Fri, 23 Oct 2015 15:05:23 +0000 [thread overview]
Message-ID: <af09da26773f4aafb4f567ca1c67b8b0@EXCHOS30.ornl.gov> (raw)
In-Reply-To: <1445574603-4023-1-git-send-email-Nilesh.Kokane05@gmail.com>
>Fixed- Return of an errno should typically be negative (ie: return -EAGAIN)
>
>Signed-off-by: Nilesh Kokane <Nilesh.Kokane05@gmail.com>
>---
> drivers/staging/lustre/lnet/lnet/lib-move.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
Bad idea. I also made this mistake and it broke LNet really badly.
prev parent reply other threads:[~2015-10-23 15:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 4:30 Nilesh Kokane
2015-10-23 5:00 ` Dan Carpenter
2015-10-23 6:45 ` Dan Carpenter
2015-10-23 11:40 ` Dilger, Andreas
2015-10-23 12:09 ` Nilesh Kokane
2015-10-23 15:05 ` Simmons, James A. [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af09da26773f4aafb4f567ca1c67b8b0@EXCHOS30.ornl.gov \
--to=simmonsja@ornl.gov \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nilesh.kokane05@gmail.com \
--cc=oleg.drokin@intel.com \
--cc=suneel.raikar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®