[PATCH RESEND] arm64: defconfig: qcom: enable X1E80100 sound card

[PATCH RESEND] arm64: defconfig: qcom: enable X1E80100 sound card

[Krzysztof Kozlowski]

Enable the sound machine driver for Qualcomm X1E80100 sound card, used
on several boards with X1E80100 (e.g. X1E80100 CRD).

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

The driver and bindings were posted here:
https://lore.kernel.org/alsa-devel/20231204100116.211898-1-krzysztof.kozlowski@linaro.org/T/#t

Resending because I did not Cc Bjorn/Konrad/MSM.
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 94e677800899..4df6a724349f 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -956,6 +956,7 @@ CONFIG_SND_SOC_SM8250=m
 CONFIG_SND_SOC_SC8280XP=m
 CONFIG_SND_SOC_SC7180=m
 CONFIG_SND_SOC_SC7280=m
+CONFIG_SND_SOC_X1E80100=m
 CONFIG_SND_SOC_ROCKCHIP=m
 CONFIG_SND_SOC_ROCKCHIP_I2S_TDM=m
 CONFIG_SND_SOC_ROCKCHIP_SPDIF=m
-- 
2.34.1

Re: [PATCH RESEND] arm64: defconfig: qcom: enable X1E80100 sound card

[Dmitry Baryshkov]

On Wed, 3 Apr 2024 at 12:45, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Enable the sound machine driver for Qualcomm X1E80100 sound card, used
> on several boards with X1E80100 (e.g. X1E80100 CRD).
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> The driver and bindings were posted here:
> https://lore.kernel.org/alsa-devel/20231204100116.211898-1-krzysztof.kozlowski@linaro.org/T/#t
>
> Resending because I did not Cc Bjorn/Konrad/MSM.
> ---
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>


-- 
With best wishes
Dmitry

Re: [PATCH RESEND] arm64: defconfig: qcom: enable X1E80100 sound card

[Bjorn Andersson]

On Wed, Apr 03, 2024 at 11:44:22AM +0200, Krzysztof Kozlowski wrote:
> Enable the sound machine driver for Qualcomm X1E80100 sound card, used
> on several boards with X1E80100 (e.g. X1E80100 CRD).
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 

I'm completely lost on your strategy for these sound card drivers!

Why is x1e a separate driver when we're shoehorning in qc*6490 into the
sc8280xp?
Why does Srini answer me that the compatible should contain the device
name (qcom,qcs6490-rb3gen2-sndcard) while you're at the same time adding
a platform-based compatible for x1e.
 
PS. The only answer I get out of `diff -u sc8280xp.c x1e80100.c` is that
we're going to blow some speakers on X1E devices. (And is this
limitation applicable to qc?6490 devices?)



Obviously unrelated to this patch, which I will pick.

Regards,
Bjorn

> ---
> 
> The driver and bindings were posted here:
> https://lore.kernel.org/alsa-devel/20231204100116.211898-1-krzysztof.kozlowski@linaro.org/T/#t
> 
> Resending because I did not Cc Bjorn/Konrad/MSM.
> ---
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 94e677800899..4df6a724349f 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -956,6 +956,7 @@ CONFIG_SND_SOC_SM8250=m
>  CONFIG_SND_SOC_SC8280XP=m
>  CONFIG_SND_SOC_SC7180=m
>  CONFIG_SND_SOC_SC7280=m
> +CONFIG_SND_SOC_X1E80100=m
>  CONFIG_SND_SOC_ROCKCHIP=m
>  CONFIG_SND_SOC_ROCKCHIP_I2S_TDM=m
>  CONFIG_SND_SOC_ROCKCHIP_SPDIF=m
> -- 
> 2.34.1
> 

Re: [PATCH RESEND] arm64: defconfig: qcom: enable X1E80100 sound card

[Krzysztof Kozlowski]

On 20/04/2024 20:13, Bjorn Andersson wrote:
> On Wed, Apr 03, 2024 at 11:44:22AM +0200, Krzysztof Kozlowski wrote:
>> Enable the sound machine driver for Qualcomm X1E80100 sound card, used
>> on several boards with X1E80100 (e.g. X1E80100 CRD).
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
> 
> I'm completely lost on your strategy for these sound card drivers!
> 
> Why is x1e a separate driver when we're shoehorning in qc*6490 into the
> sc8280xp?

Because x1e is different. It has 4 speakers. sc8280xp does not have four
speakers.

> Why does Srini answer me that the compatible should contain the device
> name (qcom,qcs6490-rb3gen2-sndcard) while you're at the same time adding
> a platform-based compatible for x1e.

That's defconfig change... But yeah, probably x1e sound card should be
tied to the board model. I prepared and sent the patches much earlier,
before qcom,qcs6490-rb3gen2-sndcard came to discussion.

For most of the boards I would just go with generic soc compatible. I
think I provided rationale qcs6490 discussion.

Best regards,
Krzysztof

Re: [PATCH RESEND] arm64: defconfig: qcom: enable X1E80100 sound card

[Bjorn Andersson]

On Wed, 03 Apr 2024 11:44:22 +0200, Krzysztof Kozlowski wrote:
> Enable the sound machine driver for Qualcomm X1E80100 sound card, used
> on several boards with X1E80100 (e.g. X1E80100 CRD).
> 
> 

Applied, thanks!

[1/1] arm64: defconfig: qcom: enable X1E80100 sound card
      commit: bfff021ebf0beadc4fe8eeba252b35a188db2c6e

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>