mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kernel test robot <yujie.liu@intel.com>
To: Arun Easi <aeasi@marvell.com>
Cc: <kbuild-all@lists.01.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Himanshu Madhani <himanshu.madhani@oracle.com>,
	Nilesh Javali <njavali@marvell.com>
Subject: [mkp-scsi:for-next 59/141] checkpatch: WARNING: debugfs_remove(NULL) is safe and this check is probably not required
Date: Tue, 27 Sep 2022 09:26:19 +0800	[thread overview]
Message-ID: <af34adb9-7772-f96a-ca36-73e898a3419e@intel.com> (raw)
In-Reply-To: <6330e3af.23eSa2zDsViptpST%lkp@intel.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
head:   57569c37f0add1b6489e1a1563c71519daf732cf
commit: 389f179b868e43121c6cfccfbf5e495842a766fd [59/141] scsi: qla2xxx: Add debugfs create/delete helpers
reproduce:
         scripts/checkpatch.pl 0001-scsi-qla2xxx-Add-debugfs-create-delete-helpers.patch

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <yujie.liu@intel.com>

# many are suggestions rather than must-fix

WARNING: macros should not use a trailing semicolon
#71: drivers/scsi/qla2xxx/qla_dfs.c:521:
+#define QLA_DFS_SETUP_RD(_name, _ctx_struct)				\
+static int								\
+qla_dfs_##_name##_open(struct inode *inode, struct file *file)		\
+{									\
+	_ctx_struct *__ctx = inode->i_private;				\
+									\
+	return single_open(file, qla_dfs_##_name##_show, __ctx);	\
+}									\
+									\
+static const struct file_operations qla_dfs_##_name##_ops = {		\
+	.open           = qla_dfs_##_name##_open,			\
+	.read           = seq_read,					\
+	.llseek         = seq_lseek,					\
+	.release        = single_release,				\
+};

WARNING: macros should not use a trailing semicolon
#87: drivers/scsi/qla2xxx/qla_dfs.c:537:
+#define QLA_DFS_SETUP_RW(_name, _ctx_struct)				\
+static int								\
+qla_dfs_##_name##_open(struct inode *inode, struct file *file)		\
+{									\
+	_ctx_struct *__ctx = inode->i_private;				\
+									\
+	return single_open(file, qla_dfs_##_name##_show, __ctx);	\
+}									\
+									\
+static const struct file_operations qla_dfs_##_name##_ops = {		\
+	.open           = qla_dfs_##_name##_open,			\
+	.read           = seq_read,					\
+	.llseek         = seq_lseek,					\
+	.release        = single_release,				\
+	.write		= qla_dfs_##_name##_write,			\
+};

WARNING: debugfs_remove(NULL) is safe and this check is probably not required
#115: drivers/scsi/qla2xxx/qla_dfs.c:565:
+		if (qla_dfs_##_name) {					\
+			debugfs_remove(qla_dfs_##_name);		\

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

           reply	other threads:[~2022-09-27  1:26 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <6330e3af.23eSa2zDsViptpST%lkp@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af34adb9-7772-f96a-ca36-73e898a3419e@intel.com \
    --to=yujie.liu@intel.com \
    --cc=aeasi@marvell.com \
    --cc=himanshu.madhani@oracle.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=njavali@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®