* [mkp-scsi:for-next 59/141] checkpatch: WARNING: debugfs_remove(NULL) is safe and this check is probably not required
[not found] <6330e3af.23eSa2zDsViptpST%lkp@intel.com>
@ 2022-09-27 1:26 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2022-09-27 1:26 UTC (permalink / raw)
To: Arun Easi
Cc: kbuild-all, Linux Kernel Mailing List, Martin K. Petersen,
Himanshu Madhani, Nilesh Javali
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
head: 57569c37f0add1b6489e1a1563c71519daf732cf
commit: 389f179b868e43121c6cfccfbf5e495842a766fd [59/141] scsi: qla2xxx: Add debugfs create/delete helpers
reproduce:
scripts/checkpatch.pl 0001-scsi-qla2xxx-Add-debugfs-create-delete-helpers.patch
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <yujie.liu@intel.com>
# many are suggestions rather than must-fix
WARNING: macros should not use a trailing semicolon
#71: drivers/scsi/qla2xxx/qla_dfs.c:521:
+#define QLA_DFS_SETUP_RD(_name, _ctx_struct) \
+static int \
+qla_dfs_##_name##_open(struct inode *inode, struct file *file) \
+{ \
+ _ctx_struct *__ctx = inode->i_private; \
+ \
+ return single_open(file, qla_dfs_##_name##_show, __ctx); \
+} \
+ \
+static const struct file_operations qla_dfs_##_name##_ops = { \
+ .open = qla_dfs_##_name##_open, \
+ .read = seq_read, \
+ .llseek = seq_lseek, \
+ .release = single_release, \
+};
WARNING: macros should not use a trailing semicolon
#87: drivers/scsi/qla2xxx/qla_dfs.c:537:
+#define QLA_DFS_SETUP_RW(_name, _ctx_struct) \
+static int \
+qla_dfs_##_name##_open(struct inode *inode, struct file *file) \
+{ \
+ _ctx_struct *__ctx = inode->i_private; \
+ \
+ return single_open(file, qla_dfs_##_name##_show, __ctx); \
+} \
+ \
+static const struct file_operations qla_dfs_##_name##_ops = { \
+ .open = qla_dfs_##_name##_open, \
+ .read = seq_read, \
+ .llseek = seq_lseek, \
+ .release = single_release, \
+ .write = qla_dfs_##_name##_write, \
+};
WARNING: debugfs_remove(NULL) is safe and this check is probably not required
#115: drivers/scsi/qla2xxx/qla_dfs.c:565:
+ if (qla_dfs_##_name) { \
+ debugfs_remove(qla_dfs_##_name); \
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] only message in thread