re: commit 23cb8490c0d3 ("MAINTAINERS: fix bad file pattern")

re: commit 23cb8490c0d3 ("MAINTAINERS: fix bad file pattern")

[Joe Perches]

   MAINTAINERS: fix bad file pattern
    
    Testing 'parse-maintainers' due to the previous commit shows a bad file
    pattern for the "TI VPE/CAL DRIVERS" entry in the MAINTAINERS file.
    
    There's also a lot of mis-ordered entries, but I'm still a bit nervous
    about the inevitable and annoying merge problems it would probably cause
    to fix them up.
    
    The MAINTAINERS file is one of my least favorite files due to being huge
    and centralized, but fixing it is also horribly painful for that reason.

The identical commit was sent at least twice.
Once directly to you.

https://patchwork.kernel.org/patch/11361131/
https://lore.kernel.org/linux-media/20200128145828.74161-1-andriy.shevchenko@linux.intel.com/


About the pain associated to fixing the file:
I think it would be minimally painful to run

$ ./scripts/parse-maintainers.pl --input=MAINTAINERS --output=MAINTAINERS --order

Immediately before an -rc1 is released.

Relatively few of any pending patches to MAINTAINERS
in -next would be impacted and there would be better
consistency in the silly file.

Re: commit 23cb8490c0d3 ("MAINTAINERS: fix bad file pattern")

[Andy Shevchenko]

On Mon, Mar 30, 2020 at 5:38 AM Joe Perches <joe@perches.com> wrote:
>
>    MAINTAINERS: fix bad file pattern
>
>     Testing 'parse-maintainers' due to the previous commit shows a bad file
>     pattern for the "TI VPE/CAL DRIVERS" entry in the MAINTAINERS file.
>
>     There's also a lot of mis-ordered entries, but I'm still a bit nervous
>     about the inevitable and annoying merge problems it would probably cause
>     to fix them up.

I'm wondering if order depends to current locale. If so, the script
should override locale as well.

>
>     The MAINTAINERS file is one of my least favorite files due to being huge
>     and centralized, but fixing it is also horribly painful for that reason.
>
> The identical commit was sent at least twice.
> Once directly to you.
>
> https://patchwork.kernel.org/patch/11361131/
> https://lore.kernel.org/linux-media/20200128145828.74161-1-andriy.shevchenko@linux.intel.com/
>
>
> About the pain associated to fixing the file:
> I think it would be minimally painful to run
>
> $ ./scripts/parse-maintainers.pl --input=MAINTAINERS --output=MAINTAINERS --order
>
> Immediately before an -rc1 is released.
>
> Relatively few of any pending patches to MAINTAINERS
> in -next would be impacted and there would be better
> consistency in the silly file.
>
>


-- 
With Best Regards,
Andy Shevchenko

Re: commit 23cb8490c0d3 ("MAINTAINERS: fix bad file pattern")

[Joe Perches]

On Mon, 2020-03-30 at 10:35 +0300, Andy Shevchenko wrote:
> On Mon, Mar 30, 2020 at 5:38 AM Joe Perches <joe@perches.com> wrote:
> >    MAINTAINERS: fix bad file pattern
> > 
> >     Testing 'parse-maintainers' due to the previous commit shows a bad file
> >     pattern for the "TI VPE/CAL DRIVERS" entry in the MAINTAINERS file.
> > 
> >     There's also a lot of mis-ordered entries, but I'm still a bit nervous
> >     about the inevitable and annoying merge problems it would probably cause
> >     to fix them up.
> 
> I'm wondering if order depends to current locale. If so, the script
> should override locale as well.

Perhaps:
---
diff --git a/scripts/parse-maintainers.pl b/scripts/parse-maintainers.pl
index 2ca4eb3..08db9b 100755
--- a/scripts/parse-maintainers.pl
+++ b/scripts/parse-maintainers.pl
@@ -3,6 +3,7 @@
 
 use strict;
 use Getopt::Long qw(:config no_auto_abbrev);
+no locale;
 
 my $input_file = "MAINTAINERS";
 my $output_file = "MAINTAINERS.new";

Request to sort MAINTAINERS again just before an -rc1 release

[Joe Perches]

Please consider running and committing:

$ ./scripts/parse-maintainers.pl --input=MAINTAINERS --output=MAINTAINERS --order

Immediately before any upcoming -rc1 is released.

Relatively few of any pending patches to MAINTAINERS
in -next would be impacted and there would be better
consistency in the file.

Thanks.

Re: Request to sort MAINTAINERS again just before an -rc1 release

[Linus Torvalds]

On Sat, Apr 11, 2020 at 9:45 AM Joe Perches <joe@perches.com> wrote:
>
> Please consider running and committing:
>
> $ ./scripts/parse-maintainers.pl --input=MAINTAINERS --output=MAINTAINERS --order

Ok, done. Let's see how painful this ends up being..

               Linus

Re: Request to sort MAINTAINERS again just before an -rc1 release

[Joe Perches]

On Sun, 2020-04-12 at 11:08 -0700, Linus Torvalds wrote:
> On Sat, Apr 11, 2020 at 9:45 AM Joe Perches <joe@perches.com> wrote:
> > Please consider running and committing:
> > 
> > $ ./scripts/parse-maintainers.pl --input=MAINTAINERS --output=MAINTAINERS --order
> 
> Ok, done. Let's see how painful this ends up being..

Thanks.

Hopefully, it's not too bad as were only 4 diff sections
for MAINTAINERS between your tree and the latest -next
before these changes.

$ diff -urN MAINTAINERS ../next/MAINTAINERS
--- MAINTAINERS	2020-04-12 12:40:53.261770465 -0700
+++ ../next/MAINTAINERS	2020-04-11 22:10:49.051770733 -0700
@@ -2259,6 +2259,8 @@
 L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
 L:	linux-realtek-soc@lists.infradead.org (moderated for non-subscribers)
 S:	Maintained
+F:	arch/arm/boot/dts/rtd*
+F:	arch/arm/mach-realtek/
 F:	arch/arm64/boot/dts/realtek/
 F:	Documentation/devicetree/bindings/arm/realtek.yaml
 
@@ -5959,6 +5961,7 @@
 S:	Maintained
 F:	include/linux/dim.h
 F:	lib/dim/
+F:	Documentation/networking/net_dim.rst
 
 DZ DECSTATION DZ11 SERIAL DRIVER
 M:	"Maciej W. Rozycki" <macro@linux-mips.org>
@@ -9155,6 +9158,17 @@
 F:	scripts/kconfig/
 F:	scripts/Kconfig.include
 
+KCSAN
+M:	Marco Elver <elver@google.com>
+R:	Dmitry Vyukov <dvyukov@google.com>
+L:	kasan-dev@googlegroups.com
+S:	Maintained
+F:	Documentation/dev-tools/kcsan.rst
+F:	include/linux/kcsan*.h
+F:	kernel/kcsan/
+F:	lib/Kconfig.kcsan
+F:	scripts/Makefile.kcsan
+
 KDUMP
 M:	Dave Young <dyoung@redhat.com>
 M:	Baoquan He <bhe@redhat.com>
@@ -9386,6 +9400,13 @@
 F:	include/keys/
 F:	security/keys/
 
+KFIFO:
+M:	Stefani Seibold <stefani@seibold.net>
+S:	Maintained
+F:	lib/kfifo.c
+F:	include/linux/kfifo.h
+F:	samples/kfifo/
+
 KGDB / KDB /debug_core
 M:	Jason Wessel <jason.wessel@windriver.com>
 M:	Daniel Thompson <daniel.thompson@linaro.org>