mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@linux.intel.com>
To: Arnd Bergmann <arnd@arndb.de>, the arch/x86 maintainers <x86@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/mm/kaiser: avoid 32-bit/PAE build warning
Date: Wed, 6 Dec 2017 07:08:56 -0800	[thread overview]
Message-ID: <af5124d4-b2cc-7d3c-5b8e-f7381859efd6@linux.intel.com> (raw)
In-Reply-To: <CAK8P3a0ZN2ALu1tj9sm8-Lt9SsRgpbQtz91zR4MhY-Np7TQNyg@mail.gmail.com>

On 12/06/2017 07:03 AM, Arnd Bergmann wrote:
> On Wed, Dec 6, 2017 at 3:15 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> 
>> This changes the type to u64 in the architecture-independent dummy,
>> and to pteval_t in the x86 specific portion that is used when KAISER
>> is enabled, ensuring that the flags can always fit. Unfortunately,
>> pteval_t is not provided by most other architectures, so we are
>> a little bit inconsistent here.
> 
> I ran into a new regression with my patch applied, after doing more randconfig
> builds:
> 
> In file included from /git/arm-soc/include/linux/kaiser.h:5,
>                  from /git/arm-soc/arch/x86/events/intel/ds.c:4:
> arch/x86/include/asm/kaiser.h:34:10: error: unknown type name
> 'pteval_t'; did you mean 'dev_t'?
> 
> Maybe it's better to just to the last one-line change in include/linux/kaiser.h.

Hi Arnd,

Are you hitting this in -next?

The newest version of this code has a single kpti_init() function that
shouldn't have any of these problems.

  reply	other threads:[~2017-12-06 15:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-06 14:15 Arnd Bergmann
2017-12-06 15:03 ` Arnd Bergmann
2017-12-06 15:08   ` Dave Hansen [this message]
2017-12-06 16:36     ` Arnd Bergmann
2017-12-06 17:16       ` Ingo Molnar
2017-12-06 20:47         ` Arnd Bergmann
2017-12-06 21:02           ` Ingo Molnar
2018-02-14 22:12     ` Arnd Bergmann
2018-02-15  5:43       ` Greg KH
2018-02-15 15:37         ` Arnd Bergmann
2018-02-15 16:43           ` Greg KH
2018-02-15 21:00             ` Arnd Bergmann
2018-02-19 10:04               ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af5124d4-b2cc-7d3c-5b8e-f7381859efd6@linux.intel.com \
    --to=dave.hansen@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®