From: Andrey Konovalov <andrey.konovalov@linaro.org>
To: Robert Foss <robert.foss@linaro.org>
Cc: Dongchun Zhu <dongchun.zhu@mediatek.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media <linux-media@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Bingbu Cao <bingbu.cao@linux.intel.com>,
Tomasz Figa <tfiga@google.com>
Subject: Re: [PATCH v4] media: ov8856: Configure sensor for GRBG Bayer for all modes
Date: Mon, 18 Jan 2021 23:03:03 +0300 [thread overview]
Message-ID: <af6eb377-6f7a-7b08-4a28-14f1a79a9d4a@linaro.org> (raw)
In-Reply-To: <CAG3jFyuzs00KoMQ2FZfqNAE9+hULTLoXJ2ja0pO-ikS8rvKW3A@mail.gmail.com>
Hi Robert,
On 18.01.2021 22:54, Robert Foss wrote:
> I was going for row, but got a bit wild with the Ctrl-C + Ctrl-V, is
Yeah... "raw" was in my original text
> that alright with you?
Other than these few raw vs row mistypes the patch is fine for me.
My Reviewed-by tag holds.
Thanks,
Andrey
> On Mon, 18 Jan 2021 at 20:28, Andrey Konovalov
> <andrey.konovalov@linaro.org> wrote:
>>
>> Oops.. I've missed a few mistypes
>>
>> On 18.01.2021 22:18, Andrey Konovalov wrote:
>>> Hi Robert,
>>>
>>> Thanks for you patch!
>>>
>>> Reviewed-by: Andrey Konovalov <andrey.konovalov@linaro.org>
>>>
>>> On 18.01.2021 22:01, Robert Foss wrote:
>>>> The previously added modes 3264x2448 & 1632x1224 are actually
>>>> configuring the sensor for BGGR mode, this is an issue since
>>>> the mode that is exposed through V4L incorrectly is set as GRBG.
>>>>
>>>> This patch fixes the issue by moving the output crop window of
>>>> internal sensor ISP uses by one row, which means that the Bayer
>>>> pattern of the output is changed.
>>>>
>>>> From:
>>>> row 1: B G B G B G ...
>>>> row 2: G R G R G R ...
>>>> raw 3: B G B G B G ...
>> - row
>>>> ...
>>>>
>>>> To:
>>>> raw 2: G R G R G R ...
>> - row
>>>> raw 3: B G B G B G ...
>> - row
>>
>> Thanks,
>> Andrey
>>
>>>> ...
>>>>
>>>> Signed-off-by: Robert Foss <robert.foss@linaro.org>
>>>> Suggested-by: Andrey Konovalov <andrey.konovalov@linaro.org>
>>>> ---
>>>>
>>>> Changes since v1:
>>>> - Sakari: Added mode information to ov8856_mode struct
>>>> - Sakari: enum_mbus_code updated
>>>>
>>>> Changes since v2:
>>>> - Andrey: Switched approach to changing the sensor configuration
>>>> to yield identical Bayer modes for all modes
>>>>
>>>> Changes since v3:
>>>> - Andrey: Improve commit msg to explain Bayer shift better
>>>>
>>>> drivers/media/i2c/ov8856.c | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/media/i2c/ov8856.c b/drivers/media/i2c/ov8856.c
>>>> index 2f4ceaa80593..8a355135c7db 100644
>>>> --- a/drivers/media/i2c/ov8856.c
>>>> +++ b/drivers/media/i2c/ov8856.c
>>>> @@ -428,7 +428,7 @@ static const struct ov8856_reg mode_3264x2448_regs[] = {
>>>> {0x3810, 0x00},
>>>> {0x3811, 0x04},
>>>> {0x3812, 0x00},
>>>> - {0x3813, 0x02},
>>>> + {0x3813, 0x01},
>>>> {0x3814, 0x01},
>>>> {0x3815, 0x01},
>>>> {0x3816, 0x00},
>>>> @@ -821,7 +821,7 @@ static const struct ov8856_reg mode_1632x1224_regs[] = {
>>>> {0x3810, 0x00},
>>>> {0x3811, 0x02},
>>>> {0x3812, 0x00},
>>>> - {0x3813, 0x02},
>>>> + {0x3813, 0x01},
>>>> {0x3814, 0x03},
>>>> {0x3815, 0x01},
>>>> {0x3816, 0x00},
>>>>
prev parent reply other threads:[~2021-01-18 20:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 19:01 Robert Foss
2021-01-18 19:18 ` Andrey Konovalov
2021-01-18 19:28 ` Andrey Konovalov
2021-01-18 19:54 ` Robert Foss
2021-01-18 20:03 ` Andrey Konovalov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af6eb377-6f7a-7b08-4a28-14f1a79a9d4a@linaro.org \
--to=andrey.konovalov@linaro.org \
--cc=bingbu.cao@linux.intel.com \
--cc=dongchun.zhu@mediatek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robert.foss@linaro.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tfiga@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®