* [PATCH v1] nvme: Convert comma to semicolon
@ 2024-09-06 6:58 Shen Lichuan
2024-09-06 7:55 ` Sagi Grimberg
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Shen Lichuan @ 2024-09-06 6:58 UTC (permalink / raw)
To: kbusch, axboe, hch, sagi
Cc: linux-nvme, linux-kernel, opensource.kernel, Shen Lichuan
To ensure code clarity and prevent potential errors, it's advisable
to employ the ';' as a statement separator, except when ',' are
intentionally used for specific purposes.
Signed-off-by: Shen Lichuan <shenlichuan@vivo.com>
---
drivers/nvme/host/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 0dc8bcc664f2..473149ac41c1 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -4567,7 +4567,7 @@ int nvme_alloc_io_tag_set(struct nvme_ctrl *ctrl, struct blk_mq_tag_set *set,
set->flags = BLK_MQ_F_SHOULD_MERGE;
if (ctrl->ops->flags & NVME_F_BLOCKING)
set->flags |= BLK_MQ_F_BLOCKING;
- set->cmd_size = cmd_size,
+ set->cmd_size = cmd_size;
set->driver_data = ctrl;
set->nr_hw_queues = ctrl->queue_count - 1;
set->timeout = NVME_IO_TIMEOUT;
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] nvme: Convert comma to semicolon
2024-09-06 6:58 [PATCH v1] nvme: Convert comma to semicolon Shen Lichuan
@ 2024-09-06 7:55 ` Sagi Grimberg
2024-09-06 21:19 ` Keith Busch
2024-09-08 19:31 ` Sagi Grimberg
2 siblings, 0 replies; 5+ messages in thread
From: Sagi Grimberg @ 2024-09-06 7:55 UTC (permalink / raw)
To: Shen Lichuan, kbusch, axboe, hch
Cc: linux-nvme, linux-kernel, opensource.kernel
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] nvme: Convert comma to semicolon
2024-09-06 6:58 [PATCH v1] nvme: Convert comma to semicolon Shen Lichuan
2024-09-06 7:55 ` Sagi Grimberg
@ 2024-09-06 21:19 ` Keith Busch
2024-09-08 19:31 ` Sagi Grimberg
2 siblings, 0 replies; 5+ messages in thread
From: Keith Busch @ 2024-09-06 21:19 UTC (permalink / raw)
To: Shen Lichuan
Cc: axboe, hch, sagi, linux-nvme, linux-kernel, opensource.kernel
On Fri, Sep 06, 2024 at 02:58:15PM +0800, Shen Lichuan wrote:
> To ensure code clarity and prevent potential errors, it's advisable
> to employ the ';' as a statement separator, except when ',' are
> intentionally used for specific purposes.
Thanks, applied to nvme-6.12
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] nvme: Convert comma to semicolon
2024-09-06 6:58 [PATCH v1] nvme: Convert comma to semicolon Shen Lichuan
2024-09-06 7:55 ` Sagi Grimberg
2024-09-06 21:19 ` Keith Busch
@ 2024-09-08 19:31 ` Sagi Grimberg
2024-09-08 19:35 ` Sagi Grimberg
2 siblings, 1 reply; 5+ messages in thread
From: Sagi Grimberg @ 2024-09-08 19:31 UTC (permalink / raw)
To: Shen Lichuan; +Cc: linux-nvme, linux-kernel
Again (now will hopefully make it to the mailing list after some dns fixups)
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] nvme: Convert comma to semicolon
2024-09-08 19:31 ` Sagi Grimberg
@ 2024-09-08 19:35 ` Sagi Grimberg
0 siblings, 0 replies; 5+ messages in thread
From: Sagi Grimberg @ 2024-09-08 19:35 UTC (permalink / raw)
To: Shen Lichuan; +Cc: linux-nvme, linux-kernel
Testing again (sorry for the spam)...
On 9/8/24 22:31, Sagi Grimberg wrote:
> Again (now will hopefully make it to the mailing list after some dns
> fixups)
>
> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-09-08 19:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-06 6:58 [PATCH v1] nvme: Convert comma to semicolon Shen Lichuan
2024-09-06 7:55 ` Sagi Grimberg
2024-09-06 21:19 ` Keith Busch
2024-09-08 19:31 ` Sagi Grimberg
2024-09-08 19:35 ` Sagi Grimberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®