* [PATCH] drm/bridge: dw-hdmi-cec: fix inconsistent indenting warning
@ 2025-03-05 10:35 Charles Han
2025-03-06 14:01 ` neil.armstrong
0 siblings, 1 reply; 4+ messages in thread
From: Charles Han @ 2025-03-05 10:35 UTC (permalink / raw)
To: andrzej.hajda, neil.armstrong, rfoss, Laurent.pinchart, jonas,
jernej.skrabec, maarten.lankhorst, mripard, tzimmermann, airlied,
simona, festevam
Cc: dri-devel, linux-kernel, Charles Han
Fix below inconsistent indenting smatch warning.
smatch warnings:
drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c:336 dw_hdmi_cec_suspend() warn: inconsistent indenting
Signed-off-by: Charles Han <hanchunchao@inspur.com>
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
index 9549dabde941..9d5bded54e8b 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
@@ -333,9 +333,9 @@ static int dw_hdmi_cec_suspend(struct device *dev)
struct dw_hdmi_cec *cec = dev_get_drvdata(dev);
/* store interrupt status/mask registers */
- cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
- cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
- cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);
+ cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
+ cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
+ cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);
return 0;
}
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/bridge: dw-hdmi-cec: fix inconsistent indenting warning
2025-03-05 10:35 [PATCH] drm/bridge: dw-hdmi-cec: fix inconsistent indenting warning Charles Han
@ 2025-03-06 14:01 ` neil.armstrong
0 siblings, 0 replies; 4+ messages in thread
From: neil.armstrong @ 2025-03-06 14:01 UTC (permalink / raw)
To: Charles Han, andrzej.hajda, rfoss, Laurent.pinchart, jonas,
jernej.skrabec, maarten.lankhorst, mripard, tzimmermann, airlied,
simona, festevam
Cc: dri-devel, linux-kernel
On 05/03/2025 11:35, Charles Han wrote:
> Fix below inconsistent indenting smatch warning.
> smatch warnings:
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c:336 dw_hdmi_cec_suspend() warn: inconsistent indenting
>
> Signed-off-by: Charles Han <hanchunchao@inspur.com>
> ---
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
> index 9549dabde941..9d5bded54e8b 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
> @@ -333,9 +333,9 @@ static int dw_hdmi_cec_suspend(struct device *dev)
> struct dw_hdmi_cec *cec = dev_get_drvdata(dev);
>
> /* store interrupt status/mask registers */
> - cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
> - cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
> - cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);
> + cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
> + cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
> + cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);
>
> return 0;
> }
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/bridge: dw-hdmi-cec: fix inconsistent indenting warning
2025-03-25 7:46 Charles Han
@ 2025-03-30 18:00 ` Dmitry Baryshkov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2025-03-30 18:00 UTC (permalink / raw)
To: Charles Han
Cc: andrzej.hajda, neil.armstrong, rfoss, Laurent.pinchart, jonas,
jernej.skrabec, maarten.lankhorst, mripard, tzimmermann, airlied,
simona, dri-devel, linux-kernel
On Tue, Mar 25, 2025 at 03:46:54PM +0800, Charles Han wrote:
> Fix below inconsistent indenting smatch warning.
> smatch warnings:
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c:336 dw_hdmi_cec_suspend() warn: inconsistent indenting
>
> Signed-off-by: Charles Han <hanchunchao@inspur.com>
> ---
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] drm/bridge: dw-hdmi-cec: fix inconsistent indenting warning
@ 2025-03-25 7:46 Charles Han
2025-03-30 18:00 ` Dmitry Baryshkov
0 siblings, 1 reply; 4+ messages in thread
From: Charles Han @ 2025-03-25 7:46 UTC (permalink / raw)
To: andrzej.hajda, neil.armstrong, rfoss, Laurent.pinchart, jonas,
jernej.skrabec, maarten.lankhorst, mripard, tzimmermann, airlied,
simona
Cc: dri-devel, linux-kernel, Charles Han
Fix below inconsistent indenting smatch warning.
smatch warnings:
drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c:336 dw_hdmi_cec_suspend() warn: inconsistent indenting
Signed-off-by: Charles Han <hanchunchao@inspur.com>
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
index 9549dabde941..9d5bded54e8b 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
@@ -333,9 +333,9 @@ static int dw_hdmi_cec_suspend(struct device *dev)
struct dw_hdmi_cec *cec = dev_get_drvdata(dev);
/* store interrupt status/mask registers */
- cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
- cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
- cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);
+ cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
+ cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
+ cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);
return 0;
}
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-03-30 18:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-05 10:35 [PATCH] drm/bridge: dw-hdmi-cec: fix inconsistent indenting warning Charles Han
2025-03-06 14:01 ` neil.armstrong
2025-03-25 7:46 Charles Han
2025-03-30 18:00 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®