mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hao Li <hao.li@linux.dev>
To: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Cc: Vlastimil Babka <vbabka@kernel.org>, Harry Yoo <harry@kernel.org>,
	 Andrew Morton <akpm@linux-foundation.org>,
	Christoph Lameter <cl@gentwo.org>,
	 David Rientjes <rientjes@google.com>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	 Hugh Dickins <hugh@veritas.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/slab: fix probable issue of dentries registration under /sys/kernel/slab
Date: Wed, 20 May 2026 11:21:21 +0800	[thread overview]
Message-ID: <ag0n27-TUg6BwKfK@fedora> (raw)
In-Reply-To: <20260520011019.1707010-1-vladimir.zapolskiy@linaro.org>

On Wed, May 20, 2026 at 04:10:19AM +0300, Vladimir Zapolskiy wrote:
> L2TP/IP and L2TP/IPv6 protocol names contain a slash symbol, however these
> names are blindly used as symlinks to slab cache objects registered under
> /sys/kernel/slab. This kind of symlink creation is successful, but its
> dentry is obviously broken, as well it breaks the access to the list of
> /sys/kernel/slab dentries.
> 
> Likely L2TP protocol renames cannot be done, since the defined protocol
> names are exposed over /proc/net/protocols for years, but the symlink
> names can be renamed, because they are yet to be properly created, and
> this should be eventually done by this change.
> 
> The problem manifests itself, if CONFIG_L2TP_IP build symbol is selected.

Hello, thanks for the patch.

Could L2TP possibly be loaded as a module? I noticed that
__kmem_cache_create_args can also call into sysfs_slab_alias. If L2TP is loaded
as a module after boot and dynamically creates a slub cache, it may bypass your
fix..

-- 
Thanks,
Hao

  reply	other threads:[~2026-05-20  3:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-20  1:10 Vladimir Zapolskiy
2026-05-20  3:21 ` Hao Li [this message]
2026-05-20  8:49   ` Vladimir Zapolskiy
2026-05-20  3:42 ` Harry Yoo
2026-05-21 11:24   ` Vladimir Zapolskiy
2026-05-22  1:31     ` Harry Yoo
2026-05-22  2:11       ` Harry Yoo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ag0n27-TUg6BwKfK@fedora \
    --to=hao.li@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=cl@gentwo.org \
    --cc=harry@kernel.org \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=vbabka@kernel.org \
    --cc=vladimir.zapolskiy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome