* [PATCH next] soc: qcom: llcc-qcom: Fix NULL vs IS_ERR() bug in qcom_llcc_get_fw_config()
@ 2026-05-20 6:00 Dan Carpenter
2026-05-20 8:06 ` Mukesh Ojha
2026-05-23 2:19 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2026-05-20 6:00 UTC (permalink / raw)
To: Francisco Munoz Ruiz
Cc: Bjorn Andersson, Konrad Dybcio, linux-arm-msm, linux-kernel,
kernel-janitors
The devm_memremap() function doesn't return NULL, it returns error
pointers. Fix the error checking to match.
Fixes: ac23106a9b9a ("soc: qcom: llcc-qcom: get SCT descriptors from fw-populated memory")
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
drivers/soc/qcom/llcc-qcom.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
index dcc08f63e020..2006bfe198ea 100644
--- a/drivers/soc/qcom/llcc-qcom.c
+++ b/drivers/soc/qcom/llcc-qcom.c
@@ -5231,9 +5231,9 @@ static int qcom_llcc_get_fw_config(struct platform_device *pdev)
}
slc_mem = devm_memremap(dev, res.start, resource_size(&res), MEMREMAP_WB);
- if (!slc_mem) {
+ if (IS_ERR(slc_mem)) {
dev_err(dev, "Failed to memremap SLC shared memory\n");
- return -ENOMEM;
+ return PTR_ERR(slc_mem);
}
ret = qcom_llcc_verify_fw_config(dev, slc_mem);
--
2.53.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH next] soc: qcom: llcc-qcom: Fix NULL vs IS_ERR() bug in qcom_llcc_get_fw_config()
2026-05-20 6:00 [PATCH next] soc: qcom: llcc-qcom: Fix NULL vs IS_ERR() bug in qcom_llcc_get_fw_config() Dan Carpenter
@ 2026-05-20 8:06 ` Mukesh Ojha
2026-05-23 2:19 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Mukesh Ojha @ 2026-05-20 8:06 UTC (permalink / raw)
To: Dan Carpenter
Cc: Francisco Munoz Ruiz, Bjorn Andersson, Konrad Dybcio,
linux-arm-msm, linux-kernel, kernel-janitors
On Wed, May 20, 2026 at 09:00:30AM +0300, Dan Carpenter wrote:
> The devm_memremap() function doesn't return NULL, it returns error
> pointers. Fix the error checking to match.
>
> Fixes: ac23106a9b9a ("soc: qcom: llcc-qcom: get SCT descriptors from fw-populated memory")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Duplicate patch
https://lore.kernel.org/lkml/20260519023841.1995542-1-nichen@iscas.ac.cn/
> ---
> drivers/soc/qcom/llcc-qcom.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
> index dcc08f63e020..2006bfe198ea 100644
> --- a/drivers/soc/qcom/llcc-qcom.c
> +++ b/drivers/soc/qcom/llcc-qcom.c
> @@ -5231,9 +5231,9 @@ static int qcom_llcc_get_fw_config(struct platform_device *pdev)
> }
>
> slc_mem = devm_memremap(dev, res.start, resource_size(&res), MEMREMAP_WB);
> - if (!slc_mem) {
> + if (IS_ERR(slc_mem)) {
> dev_err(dev, "Failed to memremap SLC shared memory\n");
> - return -ENOMEM;
> + return PTR_ERR(slc_mem);
> }
>
> ret = qcom_llcc_verify_fw_config(dev, slc_mem);
> --
> 2.53.0
>
--
-Mukesh Ojha
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH next] soc: qcom: llcc-qcom: Fix NULL vs IS_ERR() bug in qcom_llcc_get_fw_config()
2026-05-20 6:00 [PATCH next] soc: qcom: llcc-qcom: Fix NULL vs IS_ERR() bug in qcom_llcc_get_fw_config() Dan Carpenter
2026-05-20 8:06 ` Mukesh Ojha
@ 2026-05-23 2:19 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2026-05-23 2:19 UTC (permalink / raw)
To: Francisco Munoz Ruiz, Dan Carpenter
Cc: Konrad Dybcio, linux-arm-msm, linux-kernel, kernel-janitors
On Wed, 20 May 2026 09:00:30 +0300, Dan Carpenter wrote:
> The devm_memremap() function doesn't return NULL, it returns error
> pointers. Fix the error checking to match.
>
>
Applied, thanks!
[1/1] soc: qcom: llcc-qcom: Fix NULL vs IS_ERR() bug in qcom_llcc_get_fw_config()
commit: db0ec1ad723187a3428145b05d4a230d5b6f7e32
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-23 2:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-05-20 6:00 [PATCH next] soc: qcom: llcc-qcom: Fix NULL vs IS_ERR() bug in qcom_llcc_get_fw_config() Dan Carpenter
2026-05-20 8:06 ` Mukesh Ojha
2026-05-23 2:19 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®