mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH RESEND] soundwire: intel_ace2x: release bpt_stream when close it
@ 2026-05-14 14:16 Bard Liao
  2026-05-17 16:19 ` Vinod Koul
  2026-05-17 16:20 ` Vinod Koul
  0 siblings, 2 replies; 3+ messages in thread
From: Bard Liao @ 2026-05-14 14:16 UTC (permalink / raw)
  To: linux-sound, vkoul
  Cc: vinod.koul, linux-kernel, pierre-louis.bossart, peter.ujfalusi,
	bard.liao

The BPT stream was allocated in intel_ace2x_bpt_open_stream(), we need
to free it in intel_ace2x_bpt_close_stream().

Fixes: 4c1ce9f37d8a8 ("soundwire: intel_ace2x: add BPT send_async/wait callbacks")

Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Simon Trimmer <simont@opensource.cirrus.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
---
 drivers/soundwire/intel_ace2x.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soundwire/intel_ace2x.c b/drivers/soundwire/intel_ace2x.c
index 0a97253fe0c2..b37933efac5d 100644
--- a/drivers/soundwire/intel_ace2x.c
+++ b/drivers/soundwire/intel_ace2x.c
@@ -317,6 +317,7 @@ static void intel_ace2x_bpt_close_stream(struct sdw_intel *sdw, struct sdw_slave
 		dev_err(cdns->dev, "%s: remove slave failed: %d\n",
 			__func__, ret);
 
+	sdw_release_stream(cdns->bus.bpt_stream);
 	cdns->bus.bpt_stream = NULL;
 }
 
-- 
2.43.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH RESEND] soundwire: intel_ace2x: release bpt_stream when close it
  2026-05-14 14:16 [PATCH RESEND] soundwire: intel_ace2x: release bpt_stream when close it Bard Liao
@ 2026-05-17 16:19 ` Vinod Koul
  2026-05-17 16:20 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2026-05-17 16:19 UTC (permalink / raw)
  To: Bard Liao
  Cc: linux-sound, linux-kernel, pierre-louis.bossart, peter.ujfalusi,
	bard.liao

On 14-05-26, 22:16, Bard Liao wrote:
> The BPT stream was allocated in intel_ace2x_bpt_open_stream(), we need
> to free it in intel_ace2x_bpt_close_stream().
> 
> Fixes: 4c1ce9f37d8a8 ("soundwire: intel_ace2x: add BPT send_async/wait callbacks")
> 
No blank line here please, I have fixed it up while applying

> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
> Reviewed-by: Simon Trimmer <simont@opensource.cirrus.com>
> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
> ---
>  drivers/soundwire/intel_ace2x.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/soundwire/intel_ace2x.c b/drivers/soundwire/intel_ace2x.c
> index 0a97253fe0c2..b37933efac5d 100644
> --- a/drivers/soundwire/intel_ace2x.c
> +++ b/drivers/soundwire/intel_ace2x.c
> @@ -317,6 +317,7 @@ static void intel_ace2x_bpt_close_stream(struct sdw_intel *sdw, struct sdw_slave
>  		dev_err(cdns->dev, "%s: remove slave failed: %d\n",
>  			__func__, ret);
>  
> +	sdw_release_stream(cdns->bus.bpt_stream);
>  	cdns->bus.bpt_stream = NULL;
>  }
>  
> -- 
> 2.43.0

-- 
~Vinod

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH RESEND] soundwire: intel_ace2x: release bpt_stream when close it
  2026-05-14 14:16 [PATCH RESEND] soundwire: intel_ace2x: release bpt_stream when close it Bard Liao
  2026-05-17 16:19 ` Vinod Koul
@ 2026-05-17 16:20 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2026-05-17 16:20 UTC (permalink / raw)
  To: linux-sound, Bard Liao
  Cc: vinod.koul, linux-kernel, pierre-louis.bossart, peter.ujfalusi,
	bard.liao


On Thu, 14 May 2026 22:16:25 +0800, Bard Liao wrote:
> The BPT stream was allocated in intel_ace2x_bpt_open_stream(), we need
> to free it in intel_ace2x_bpt_close_stream().
> 
> Fixes: 4c1ce9f37d8a8 ("soundwire: intel_ace2x: add BPT send_async/wait callbacks")
> 
> 

Applied, thanks!

[1/1] soundwire: intel_ace2x: release bpt_stream when close it
      commit: 8a7fe10eec64bfb7cf4091bca540de4c55d56bfa

Best regards,
-- 
~Vinod



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-05-17 16:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-05-14 14:16 [PATCH RESEND] soundwire: intel_ace2x: release bpt_stream when close it Bard Liao
2026-05-17 16:19 ` Vinod Koul
2026-05-17 16:20 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®